From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Swosf-0007a5-Om
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 02:27:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Swose-00044j-Ly
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 02:27:33 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:50601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Swose-00044Y-Fr
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 02:27:32 -0400
Message-ID: <501A1DD0.5000806@weilnetz.de>
Date: Thu, 02 Aug 2012 08:27:28 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1343868517-11852-1-git-send-email-afaerber@suse.de>
	<1343868517-11852-2-git-send-email-afaerber@suse.de>
In-Reply-To: <1343868517-11852-2-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.2 1/4] qemu-thread: Let
 qemu_thread_is_self() return bool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Am 02.08.2012 02:48, schrieb Andreas F=C3=A4rber:
> qemu_cpu_is_self(), passing the return value through, will later be
> adapted to return bool as well.
>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>   qemu-thread-posix.c |    2 +-
>   qemu-thread-win32.c |    2 +-
>   qemu-thread.h       |    3 ++-
>   3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
> index 9e1b5fb..8fbabda 100644
> --- a/qemu-thread-posix.c
> +++ b/qemu-thread-posix.c
> @@ -151,7 +151,7 @@ void qemu_thread_get_self(QemuThread *thread)
>       thread->thread =3D pthread_self();
>   }
>  =20
> -int qemu_thread_is_self(QemuThread *thread)
> +bool qemu_thread_is_self(QemuThread *thread)
>   {
>      return pthread_equal(pthread_self(), thread->thread);
>   }
> diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
> index 3524c8b..177b398 100644
> --- a/qemu-thread-win32.c
> +++ b/qemu-thread-win32.c
> @@ -330,7 +330,7 @@ HANDLE qemu_thread_get_handle(QemuThread *thread)
>       return handle;
>   }
>  =20
> -int qemu_thread_is_self(QemuThread *thread)
> +bool qemu_thread_is_self(QemuThread *thread)
>   {
>       return GetCurrentThreadId() =3D=3D thread->tid;
>   }
> diff --git a/qemu-thread.h b/qemu-thread.h
> index a78a8f2..05fdaaf 100644
> --- a/qemu-thread.h
> +++ b/qemu-thread.h
> @@ -2,6 +2,7 @@
>   #define __QEMU_THREAD_H 1
>  =20
>   #include <inttypes.h>
> +#include <stdbool.h>
>  =20
>   typedef struct QemuMutex QemuMutex;
>   typedef struct QemuCond QemuCond;
> @@ -42,7 +43,7 @@ void qemu_thread_create(QemuThread *thread,
>                           void *arg, int mode);
>   void *qemu_thread_join(QemuThread *thread);
>   void qemu_thread_get_self(QemuThread *thread);
> -int qemu_thread_is_self(QemuThread *thread);
> +bool qemu_thread_is_self(QemuThread *thread);
>   void qemu_thread_exit(void *retval);
>  =20
>   #endif

Reviewed-by: Stefan Weil <sw@weilnetz.de>