From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swoxn-00008K-6q for qemu-devel@nongnu.org; Thu, 02 Aug 2012 02:32:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swoxm-0005Dp-7E for qemu-devel@nongnu.org; Thu, 02 Aug 2012 02:32:51 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:43945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swoxm-0005Dk-12 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 02:32:50 -0400 Received: by wgbds1 with SMTP id ds1so4885624wgb.4 for ; Wed, 01 Aug 2012 23:32:49 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <501A1F0E.80508@redhat.com> Date: Thu, 02 Aug 2012 08:32:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343839312-24030-1-git-send-email-pbonzini@redhat.com> <87txwmcrvz.fsf@codemonkey.ws> In-Reply-To: <87txwmcrvz.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: yang.z.zhang@intel.com, quintela@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Il 01/08/2012 21:51, Anthony Liguori ha scritto: >> > The next two patches clean up the state of the RTC to eliminate a useless >> > duplication, and the tenth completes migration support. Still, backwards >> > migration is broken because the algorithms in the new device model are >> > pretty much completely different. Downstreams that care should include >> > both device models and pick the old one for old machine types. > Other than the few minor comments, the series looks good overall. > > Can you talk about the guests that you've tested with this? > Specifically, have you tested win2k8 64-bit? I did smoke-test most Windows versions, but I don't expect much coverage from those tests. The periodic timer is not affected by the changes, they only affect the clock. Paolo