From: Paolo Bonzini <pbonzini@redhat.com>
To: quintela@redhat.com
Cc: yang.z.zhang@intel.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V
Date: Thu, 02 Aug 2012 11:02:58 +0200 [thread overview]
Message-ID: <501A4242.6000307@redhat.com> (raw)
In-Reply-To: <87k3xh3c5h.fsf@elfo.mitica>
Il 02/08/2012 10:56, Juan Quintela ha scritto:
>> > @@ -503,8 +503,11 @@ extern const VMStateInfo vmstate_info_unused_buffer;
>> > #define VMSTATE_TIMER_TEST(_f, _s, _test) \
>> > VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *)
>> >
>> > +#define VMSTATE_TIMER_V(_f, _s, _v) \
>> > + VMSTATE_POINTER(_f, _s, _v, vmstate_info_timer, QEMUTimer *)
>> > +
>> > #define VMSTATE_TIMER(_f, _s) \
>> > - VMSTATE_TIMER_TEST(_f, _s, NULL)
>> > + VMSTATE_POINTER(_f, _s, 0, vmstate_info_timer, QEMUTimer *)
> You didn't did it, it should be something like:
>
> #define VMSTATE_TIMER(_f, _s) \
> - VMSTATE_TIMER_TEST(_f, _s, NULL)
> + VMSTATE_TIMER_V(_f, _s, 0)
I'm following the other examples:
#define VMSTATE_UINT16_EQUAL(_f, _s) \
VMSTATE_SINGLE(_f, _s, 0, vmstate_info_uint16_equal, uint16_t)
#define VMSTATE_UINT16_EQUAL_V(_f, _s, _v) \
VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint16_equal, uint16_t)
but I can change it as you indicated.
Paolo
next prev parent reply other threads:[~2012-08-02 9:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 16:41 [Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 01/10] RTC: Remove the logic to update time format when DM bit changed Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 02/10] RTC: Rename rtc_timer_update Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts are masked/unmasked Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V Paolo Bonzini
2012-08-02 8:56 ` Juan Quintela
2012-08-02 9:02 ` Paolo Bonzini [this message]
2012-08-01 16:41 ` [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it Paolo Bonzini
2012-08-01 19:48 ` Anthony Liguori
2012-08-02 9:09 ` Juan Quintela
2012-08-02 9:14 ` Paolo Bonzini
2012-08-02 9:58 ` Juan Quintela
2012-08-01 16:41 ` [Qemu-devel] [PATCH 06/10] RTC: Add divider reset support Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 07/10] RTC: Do not fire timer periodically to catch next alarm Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 08/10] RTC: Get and set time without going through s->current_tm Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 09/10] RTC: Remove the current_tm field Paolo Bonzini
2012-08-01 16:41 ` [Qemu-devel] [PATCH 10/10] RTC: Allow to migrate from old QEMU Paolo Bonzini
2012-08-01 19:51 ` [Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer Anthony Liguori
2012-08-02 6:32 ` Paolo Bonzini
2012-08-02 0:44 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A4242.6000307@redhat.com \
--to=pbonzini@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).