From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwrJt-0007IX-SS for qemu-devel@nongnu.org; Thu, 02 Aug 2012 05:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwrJp-00063Z-6Y for qemu-devel@nongnu.org; Thu, 02 Aug 2012 05:03:49 -0400 Received: from mout.web.de ([212.227.15.4]:56429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwrJo-00063T-Sl for qemu-devel@nongnu.org; Thu, 02 Aug 2012 05:03:45 -0400 Message-ID: <501A426A.9020007@web.de> Date: Thu, 02 Aug 2012 11:03:38 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20120801050241.22163.78549.stgit@bling.home> <20120801051821.22163.64385.stgit@bling.home> <5018D78A.4040704@web.de> <1343844888.6698.8.camel@bling.home> <1343850047.6698.42.camel@bling.home> In-Reply-To: <1343850047.6698.42.camel@bling.home> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig867CFFF0C634FF17A74B5A7A" Subject: Re: [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: aik@ozlabs.ru, aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig867CFFF0C634FF17A74B5A7A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-08-01 21:40, Alex Williamson wrote: > On Wed, 2012-08-01 at 12:14 -0600, Alex Williamson wrote: >> On Wed, 2012-08-01 at 09:15 +0200, Jan Kiszka wrote: >>> On 2012-08-01 07:18, Alex Williamson wrote: >>>> Signed-off-by: Alex Williamson >>>> --- >>>> >>>> MAINTAINERS | 5 +++++ >>>> configure | 12 ++++++++++++ >>>> hw/i386/Makefile.objs | 1 + >>>> 3 files changed, 18 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 2d219d2..9680d69 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -460,6 +460,11 @@ M: Gerd Hoffmann >>>> S: Maintained >>>> F: hw/usb* >>>> =20 >>>> +VFIO >>>> +M: Alex Williamson >>>> +S: Supported >>>> +F: hw/vfio* >>>> + >>>> vhost >>>> M: Michael S. Tsirkin >>>> S: Supported >>>> diff --git a/configure b/configure >>>> index c65b5f6..81108dc 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -143,6 +143,7 @@ attr=3D"" >>>> libattr=3D"" >>>> xfs=3D"" >>>> =20 >>>> +vfio_pci=3D"no" >>>> vhost_net=3D"no" >>>> kvm=3D"no" >>>> gprof=3D"no" >>>> @@ -489,6 +490,7 @@ Haiku) >>>> usb=3D"linux" >>>> kvm=3D"yes" >>>> vhost_net=3D"yes" >>>> + vfio_pci=3D"yes" >>>> if [ "$cpu" =3D "i386" -o "$cpu" =3D "x86_64" ] ; then >>>> audio_possible_drivers=3D"$audio_possible_drivers fmod" >>>> fi >>>> @@ -824,6 +826,10 @@ for opt do >>>> ;; >>>> --disable-guest-agent) guest_agent=3D"no" >>>> ;; >>>> + --disable-vfio-pci) vfio_pci=3D"no" >>>> + ;; >>>> + --enable-vfio-pci) vfio_pci=3D"yes" >>>> + ;; >>> >>> Do we need this level of control? Open question I'm just wondering ev= ery >>> time a new feature gets added together with --disable/--enable switch= es. >> >> Well, I could certainly understand if some downstream wanted to ship a= >> qemu that didn't enable device assignment. I'm sure they'd rather hav= e >> a config option to do that instead of needing to modify code. I >> generally find --enable useful to force an error and tell me what I'm >> missing when I specifically want a feature rather than having it >> silently disabled. =20 >> >>>> *) echo "ERROR: unknown option $opt"; show_help=3D"yes" >>>> ;; >>>> esac >>>> @@ -1112,6 +1118,8 @@ echo " --disable-guest-agent disable build= ing of the QEMU Guest Agent" >>>> echo " --enable-guest-agent enable building of the QEMU Guest = Agent" >>>> echo " --with-coroutine=3DBACKEND coroutine backend. Supported opt= ions:" >>>> echo " gthread, ucontext, sigaltstack, wi= ndows" >>>> +echo " --disable-vfio-pci disable vfio pci device assignemen= t support" >>>> +echo " --enable-vfio-pci enable vfio pci device assignment = support" >>>> echo "" >>>> echo "NOTE: The object files are built at the place where configure= is launched" >>>> exit 1 >>>> @@ -3072,6 +3080,7 @@ echo "OpenGL support $opengl" >>>> echo "libiscsi support $libiscsi" >>>> echo "build guest agent $guest_agent" >>>> echo "coroutine backend $coroutine_backend" >>>> +echo "VFIO PCI support $vfio_pci" >>>> =20 >>>> if test "$sdl_too_old" =3D "yes"; then >>>> echo "-> Your SDL version is too old - please upgrade to have SDL s= upport" >>>> @@ -3754,6 +3763,9 @@ case "$target_arch2" in >>>> *) >>>> echo "CONFIG_NO_XEN=3Dy" >> $config_target_mak >>>> esac >>>> +if test "$vfio_pci" =3D "yes" -a "$target_softmmu" =3D "yes" ; then= >>>> + echo "CONFIG_VFIO_PCI=3Dy" >> $config_target_mak >>>> +fi >>> >>> Does this already somehow depend on host =3D=3D Linux? If not, you ma= y break >>> the others. >> >> Hmm, probably missing that, I'll look where to add it. Thanks, >=20 > Or I'm just forgetful. This is handled by the vfio_pci=3D"yes" in the > second chunk of configure above. Thanks, Ah, ok. Then it's fine. Jan --------------enig867CFFF0C634FF17A74B5A7A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAaQmoACgkQitSsb3rl5xRauwCgnEGB1ycf2KwNqdTObXXH6+lm 8yIAn3ZqlTCgi9PjQBbRStL3ltSwWAxb =TFpc -----END PGP SIGNATURE----- --------------enig867CFFF0C634FF17A74B5A7A--