From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwtLq-0005mX-C0 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 07:14:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwtLk-0003QV-M2 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 07:13:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwtLk-0003QK-E4 for qemu-devel@nongnu.org; Thu, 02 Aug 2012 07:13:52 -0400 Message-ID: <501A60E9.3000705@redhat.com> Date: Thu, 02 Aug 2012 13:13:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343812186-11594-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50192E62.5020200@redhat.com> <20120802111135.GN2825@redhat.com> In-Reply-To: <20120802111135.GN2825@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Eric Blake , Wenchao Xia Il 02/08/2012 13:11, Daniel P. Berrange ha scritto: >>> > > Please include GPLv2+ license headers in new source files you create. >>> > > See existing code like include/qemu/object.h for the license header >>> > > text. >> > >> > Actually, LGPLv2+ (or compatible, like BSD), if you plan on making this >> > a reusable library. GPLv2+ is too strict for libvirt to use directly. > NB, i don't see libvirt being able to use this library regardless > of license, due to its reliance on glib + abort-on-OOM behaviour Regarding glib, perhaps we could provide a small wrapper with the few functions we actually use. Paolo