From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swy2c-00033M-Ju for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:14:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swy2T-0005a0-WC for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:14:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48454 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swy2T-0005Zq-MD for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:14:17 -0400 Message-ID: <501AA756.1030201@suse.de> Date: Thu, 02 Aug 2012 18:14:14 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1343868517-11852-1-git-send-email-afaerber@suse.de> <1343868517-11852-2-git-send-email-afaerber@suse.de> <501A1DD0.5000806@weilnetz.de> In-Reply-To: <501A1DD0.5000806@weilnetz.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.2 1/4] qemu-thread: Let qemu_thread_is_self() return bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws Am 02.08.2012 08:27, schrieb Stefan Weil: > Am 02.08.2012 02:48, schrieb Andreas F=C3=A4rber: >> qemu_cpu_is_self(), passing the return value through, will later be >> adapted to return bool as well. >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> qemu-thread-posix.c | 2 +- >> qemu-thread-win32.c | 2 +- >> qemu-thread.h | 3 ++- >> 3 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c >> index 9e1b5fb..8fbabda 100644 >> --- a/qemu-thread-posix.c >> +++ b/qemu-thread-posix.c >> @@ -151,7 +151,7 @@ void qemu_thread_get_self(QemuThread *thread) >> thread->thread =3D pthread_self(); >> } >> -int qemu_thread_is_self(QemuThread *thread) >> +bool qemu_thread_is_self(QemuThread *thread) >> { >> return pthread_equal(pthread_self(), thread->thread); >> } >> diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c >> index 3524c8b..177b398 100644 >> --- a/qemu-thread-win32.c >> +++ b/qemu-thread-win32.c >> @@ -330,7 +330,7 @@ HANDLE qemu_thread_get_handle(QemuThread *thread) >> return handle; >> } >> -int qemu_thread_is_self(QemuThread *thread) >> +bool qemu_thread_is_self(QemuThread *thread) >> { >> return GetCurrentThreadId() =3D=3D thread->tid; >> } >> diff --git a/qemu-thread.h b/qemu-thread.h >> index a78a8f2..05fdaaf 100644 >> --- a/qemu-thread.h >> +++ b/qemu-thread.h >> @@ -2,6 +2,7 @@ >> #define __QEMU_THREAD_H 1 >> #include >> +#include >> typedef struct QemuMutex QemuMutex; >> typedef struct QemuCond QemuCond; >> @@ -42,7 +43,7 @@ void qemu_thread_create(QemuThread *thread, >> void *arg, int mode); >> void *qemu_thread_join(QemuThread *thread); >> void qemu_thread_get_self(QemuThread *thread); >> -int qemu_thread_is_self(QemuThread *thread); >> +bool qemu_thread_is_self(QemuThread *thread); >> void qemu_thread_exit(void *retval); >> #endif >=20 > Reviewed-by: Stefan Weil Thanks, branch updated. /-F --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg