From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures
Date: Thu, 02 Aug 2012 18:29:56 +0200 [thread overview]
Message-ID: <501AAB04.9070607@suse.de> (raw)
In-Reply-To: <CAFEAcA-oVyMMt0nxNE5VCEeq6wy-7hajQZ+VTaeOLDnDnpT+6A@mail.gmail.com>
Am 02.08.2012 18:22, schrieb Peter Maydell:
> On 2 August 2012 17:01, Andreas Färber <afaerber@suse.de> wrote:
>> One minor nit: The indentation seems off here - esac 2 spaces, if 4.
>
> configure's indentation is pretty inconsistent generally between
> 2 or 4 spaces. I usually go for 4 for new code but don't reindent
> old code. (There's a lot more 2-space than 4-space I think but
> 4 is the qemu coding style :-))
A matter of interpretation, I see our Coding Style as applying to C
code, not strictly to shell or Python or Perl code.
Why I pointed this out is because that's effectively like writing:
...
}
if (foo) {
...
}
}
So could you please either use 2-space indentation for your inserted if
or re-indent the case block above, so that there is not this break?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-08-02 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 11:10 [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures Peter Maydell
2012-08-02 15:41 ` Peter Maydell
2012-08-02 15:46 ` Andreas Färber
2012-08-02 15:53 ` Alexander Graf
2012-08-02 20:31 ` Marcelo Tosatti
2012-08-02 16:01 ` Andreas Färber
2012-08-02 16:22 ` Peter Maydell
2012-08-02 16:29 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501AAB04.9070607@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).