From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SwyHm-0000Y9-BQ
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:30:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SwyHg-0002aM-Vv
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:30:05 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52293 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SwyHg-0002Zs-Or
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 12:30:00 -0400
Message-ID: <501AAB04.9070607@suse.de>
Date: Thu, 02 Aug 2012 18:29:56 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1342609849-12618-1-git-send-email-peter.maydell@linaro.org>
	<501AA450.5080308@suse.de>
	<CAFEAcA-oVyMMt0nxNE5VCEeq6wy-7hajQZ+VTaeOLDnDnpT+6A@mail.gmail.com>
In-Reply-To: <CAFEAcA-oVyMMt0nxNE5VCEeq6wy-7hajQZ+VTaeOLDnDnpT+6A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list
 of KVM architectures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, patches@linaro.org

Am 02.08.2012 18:22, schrieb Peter Maydell:
> On 2 August 2012 17:01, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> One minor nit: The indentation seems off here - esac 2 spaces, if 4.
>=20
> configure's indentation is pretty inconsistent generally between
> 2 or 4 spaces. I usually go for 4 for new code but don't reindent
> old code. (There's a lot more 2-space than 4-space I think but
> 4 is the qemu coding style :-))

A matter of interpretation, I see our Coding Style as applying to C
code, not strictly to shell or Python or Perl code.

Why I pointed this out is because that's effectively like writing:

        ...
    }
        if (foo) {
                ...
        }
}

So could you please either use 2-space indentation for your inserted if
or re-indent the case block above, so that there is not this break?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg