From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SwylO-0001sO-6l
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:00:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SwylI-0004Hn-37
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:00:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SwylH-0004Hj-Rb
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:00:36 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q72H0ZBM018053
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 2 Aug 2012 13:00:35 -0400
Received: from dhcp-1-120.tlv.redhat.com (vpn-201-236.tlv.redhat.com
	[10.35.201.236])
	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q72H0XOX020200
	for <qemu-devel@nongnu.org>; Thu, 2 Aug 2012 13:00:34 -0400
Message-ID: <501AB240.9020900@redhat.com>
Date: Thu, 02 Aug 2012 20:00:48 +0300
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1343911494-7784-1-git-send-email-owasserm@redhat.com>
	<1343911494-7784-9-git-send-email-owasserm@redhat.com>
	<501A8779.80308@redhat.com>
In-Reply-To: <501A8779.80308@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 08/02/2012 04:58 PM, Eric Blake wrote:
> On 08/02/2012 06:44 AM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2, it will be
>> rounded down to the nearest power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> New query-migrate-cache-size QMP command and 'info migrate-cache-size' HMP
> 
> 'info migrate_cache_size' in HMP
> 
>> command to query cache value.
>>
>> Signed-off-by: Benoit Hudzia <benoit.hudzia@sap.com>
>> Signed-off-by: Petter Svard <petters@cs.umu.se>
>> Signed-off-by: Aidan Shribman <aidan.shribman@sap.com>
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
>> ---
> 
>> +++ b/monitor.c
>> @@ -2676,6 +2676,13 @@ static mon_cmd_t info_cmds[] = {
>>          .mhandler.info = hmp_info_migrate_capabilities,
>>      },
>>      {
>> +        .name       = "migrate-cache-size",
> 
> s/migrate-cache-size/migrate_cache_size/ - HMP still uses underscore
> 
will be fixed.

Orit