From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1Swyln-0002hb-9m
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:01:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1Swylh-0004UJ-Gx
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:01:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19467)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1Swylh-0004UE-9H
	for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:01:01 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q72H10hE013088
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 2 Aug 2012 13:01:00 -0400
Received: from dhcp-1-120.tlv.redhat.com (vpn-201-236.tlv.redhat.com
	[10.35.201.236])
	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q72H0x76006517
	for <qemu-devel@nongnu.org>; Thu, 2 Aug 2012 13:01:00 -0400
Message-ID: <501AB25A.5090203@redhat.com>
Date: Thu, 02 Aug 2012 20:01:14 +0300
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1343911494-7784-1-git-send-email-owasserm@redhat.com>
	<1343911494-7784-11-git-send-email-owasserm@redhat.com>
	<501A8855.9050006@redhat.com>
In-Reply-To: <501A8855.9050006@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 08/02/2012 05:01 PM, Eric Blake wrote:
> On 08/02/2012 06:44 AM, Orit Wasserman wrote:
>> Signed-off-by: Benoit Hudzia <benoit.hudzia@sap.com>
>> Signed-off-by: Petter Svard <petters@cs.umu.se>
>> Signed-off-by: Aidan Shribman <aidan.shribman@sap.com>
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
> 
> 
>>  
>> +6. Migration is being performed and XBZRLE is active:
>> +
>> +-> { "execute": "query-migrate" }
>> +<- {
>> +      "return":{
>> +         "status":"active",
>> +         "capabilities" : [ { "capability": "xbzrle", "state" : true } ],
>> +         "ram":{
>> +            "total":1057024,
>> +            "remaining":1053304,
>> +            "transferred":3720,
>> +            "duplicate": 10,
>> +            "normal": 3333
>> +         },
>> +         "xbzrle-cache":{
>> +            "cache-size": 1024,
> 
> Is this value in bytes?  It should be.  Which means that this example is
> bogus - 1024 is smaller than one page, but your caching code rounded to
> page boundaries.  Sounds like you forgot a scaling factor somewhere.
> Also, s/: /:/
> 
will be fixed,
Thanks,
Orit