From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxCjJ-0007Bt-NN for qemu-devel@nongnu.org; Fri, 03 Aug 2012 03:55:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxCjF-0003bp-MY for qemu-devel@nongnu.org; Fri, 03 Aug 2012 03:55:29 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:42878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxCjF-0003bQ-52 for qemu-devel@nongnu.org; Fri, 03 Aug 2012 03:55:25 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 17:54:48 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q737tFxY20381886 for ; Fri, 3 Aug 2012 17:55:16 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q737tFwH024993 for ; Fri, 3 Aug 2012 17:55:15 +1000 Message-ID: <501B83B0.5000000@linux.vnet.ibm.com> Date: Fri, 03 Aug 2012 15:54:24 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1343812186-11594-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50192E62.5020200@redhat.com> <20120802111135.GN2825@redhat.com> <501A60E9.3000705@redhat.com> In-Reply-To: <501A60E9.3000705@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Eric Blake 于 2012-8-2 19:13, Paolo Bonzini 写道: > Il 02/08/2012 13:11, Daniel P. Berrange ha scritto: >>>>>> Please include GPLv2+ license headers in new source files you create. >>>>>> See existing code like include/qemu/object.h for the license header >>>>>> text. >>>> >>>> Actually, LGPLv2+ (or compatible, like BSD), if you plan on making this >>>> a reusable library. GPLv2+ is too strict for libvirt to use directly. >> NB, i don't see libvirt being able to use this library regardless >> of license, due to its reliance on glib + abort-on-OOM behaviour > > Regarding glib, perhaps we could provide a small wrapper with the few > functions we actually use. > That is what I expect, replace g_malloc and g_free in the library, and reports OOM. This may changes some code in qemu block layer. > Paolo > -- Best Regards Wenchao Xia