From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxJE2-0002iK-UE for qemu-devel@nongnu.org; Fri, 03 Aug 2012 10:51:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxJDy-0007N8-Ln for qemu-devel@nongnu.org; Fri, 03 Aug 2012 10:51:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45103 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxJDy-0007My-As for qemu-devel@nongnu.org; Fri, 03 Aug 2012 10:51:34 -0400 Message-ID: <501BE572.1010509@suse.de> Date: Fri, 03 Aug 2012 16:51:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1343873409-8571-1-git-send-email-david@gibson.dropbear.id.au> <1343873409-8571-3-git-send-email-david@gibson.dropbear.id.au> <501AA071.3030406@suse.de> <87vch1i1va.fsf@codemonkey.ws> <501AC915.5080004@suse.de> <87lihx84m4.fsf@codemonkey.ws> In-Reply-To: <87lihx84m4.fsf@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: agraf@suse.de, Igor Mammedov , qemu-devel@nongnu.org, David Gibson Am 02.08.2012 21:40, schrieb Anthony Liguori: > Andreas F=C3=A4rber writes: >=20 >> Am 02.08.2012 20:29, schrieb Anthony Liguori: >>> Andreas F=C3=A4rber writes: >>> >>>> Anthony was favoring moving reset code out of machines and expressed >>>> dislike for looping through CPUs, which my above patch took into >>>> account. The ordering issue between CPU and devices is still unsolve= d there. >>>> >>>> Some on-list comments from Anthony would be nice, since we are movin= g >>>> into opposing directions here - having the sPAPR machine be more in >>>> control vs. moving code away from the PC machine into target-i386 CP= U >>>> and/or common CPU code. >>> >>> I already commented on the first patch because I had a feeling you'd >>> post something like this ;-) >> >> I was not cc'ed. :( I did read the reply wrt reset controller chip btw in case you meant that one, but it doesn't discuss QEMU API at all, only wording changes to the commit message. >>> Regarding reset: >>> >>> 1) Devices should implement DeviceState::reset() >>> >>> 2) If a device doesn't implement ::reset(), it should call >>> qemu_register_reset() >>> >>> 3) Reset should propagate through the device model, starting with the >>> top-level machine which is logically what's plugged into the wall and >>> is the source of power in the first place. >> >> So you changed your opinion over night? >=20 > No. Ben's cover letter indicated "as discussed with Anthony on a call", suggesting to me that you agree to the solution presented here! Bad choice of words then. >> I wanted to keep the reset callbacks in the machine. You applied a pat= ch >> breaking that pattern and argued you wanted to move reset code *out* o= f >> the machine. Now you say the machine should *propagate* reset. Sorry, >> that's unlogical to me... >=20 > You're not listening carefully. Just a friendly piece of advise-- > instead of sending knee-jerk emails, spend some time going back and > re-reading these discussions. >=20 > This has been discussed literally to death now for years. Mind you, you are communicating with non-native speakers and I had to look up "knee-jerk". If you have a point to make, do it clearly. Your replies have been anything but helpful to me. You find my emails knee-jerked, I find your applying Igor's second patch just before the 1.2 freeze a knee-jerk reaction. Especially considering that you apply that series but not his earlier initfn one that did not get objections any more. Two opinions. Now, I have close to 20,000 unread qemu-devel mails alone. If you have time to re-read the discussions from several years then I wonder why you are not processing more uncontroversial patches and PULLs and replying to mails. Otherwise don't ask people to do what you don't humanly manage yourself. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg