From: "Andreas Färber" <afaerber@suse.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: blauwirbel@gmail.com, Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/7] s390: sclp base support
Date: Fri, 03 Aug 2012 17:23:46 +0200 [thread overview]
Message-ID: <501BED02.2020108@suse.de> (raw)
In-Reply-To: <1343115430-34285-4-git-send-email-borntraeger@de.ibm.com>
Am 24.07.2012 09:37, schrieb Christian Borntraeger:
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> new file mode 100644
> index 0000000..4095ba6
> --- /dev/null
> +++ b/hw/s390x/sclp.c
[...]
> +
> +static TypeInfo s390_sclp_bridge_info = {
Two minor comments:
static const please.
> + .name = "s390-sclp-bridge",
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .instance_size = sizeof(SysBusDevice),
> + .class_init = s390_sclp_bridge_class_init,
> +};
> +
> +static void s390_sclp_register_types(void)
> +{
> + type_register_static(&s390_sclp_bridge_info);
> + type_register_static(&s390_sclp_bus_info);
> +}
> +type_init(s390_sclp_register_types)
Please insert a white line between the function and type_init().
Both apply to virtually all following patches as well.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-03 15:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 7:37 [Qemu-devel] [PATCH 0/7v3] s390: sclp patch set Christian Borntraeger
2012-07-24 7:37 ` [Qemu-devel] [PATCH 1/7] s390: Fix error handling and condition code of service call Christian Borntraeger
2012-07-24 7:37 ` [Qemu-devel] [PATCH 2/7] s390: provide interface for service interrupt/introduce interrupt.c Christian Borntraeger
2012-07-24 7:37 ` [Qemu-devel] [PATCH 3/7] s390: sclp base support Christian Borntraeger
2012-07-30 12:38 ` Alexander Graf
2012-07-30 14:34 ` Christian Borntraeger
2012-08-20 12:15 ` Heinz Graalfs
2012-08-03 15:23 ` Andreas Färber [this message]
2012-07-24 7:37 ` [Qemu-devel] [PATCH 4/7] s390: sclp event support Christian Borntraeger
2012-07-30 13:24 ` Alexander Graf
2012-07-30 14:46 ` Christian Borntraeger
2012-07-30 14:57 ` Alexander Graf
2012-08-20 12:15 ` Heinz Graalfs
2012-07-31 12:59 ` Andreas Färber
2012-08-03 12:31 ` Christian Borntraeger
2012-08-20 12:14 ` Heinz Graalfs
2012-07-24 7:37 ` [Qemu-devel] [PATCH 5/7] s390: sclp signal quiesce support Christian Borntraeger
2012-07-24 7:37 ` [Qemu-devel] [PATCH 6/7] s390: sclp ascii console support Christian Borntraeger
2012-07-24 19:42 ` Blue Swirl
2012-07-26 8:55 ` [Qemu-devel] [PATCH v4 06/07] " Christian Borntraeger
2012-07-30 14:02 ` Alexander Graf
2012-07-31 13:05 ` Christian Borntraeger
2012-07-24 7:37 ` [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default Christian Borntraeger
2012-07-24 19:35 ` Blue Swirl
2012-07-25 6:55 ` Christian Borntraeger
2012-07-26 13:48 ` Andreas Färber
2012-07-26 8:59 ` [Qemu-devel] [PATCH v4 07/07] " Christian Borntraeger
2012-07-30 14:05 ` Alexander Graf
2012-07-31 12:44 ` Christian Borntraeger
2012-07-31 12:52 ` Alexander Graf
2012-07-26 9:11 ` Christian Borntraeger
2012-07-30 9:00 ` [Qemu-devel] [PATCH 0/7v3] s390: sclp patch set Christian Borntraeger
2012-07-30 14:11 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501BED02.2020108@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).