qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Korolev <Alexey.Korolev@endace.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kevin@koconnor.net" <kevin@koconnor.net>,
	"seabios@seabios.org" <seabios@seabios.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	"mst@redhat.com" <mst@redhat.com>
Subject: Re: [Qemu-devel] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present
Date: Fri, 03 Aug 2012 18:29:05 +0200	[thread overview]
Message-ID: <501BFC51.5020005@redhat.com> (raw)
In-Reply-To: <D0B75B542AA3C648B838B5A90BE651C72CA7FEE1@nzhmlmbx01.ad.endace.com>

Il 26/07/2012 17:38, Alexey Korolev ha scritto:
> HI,
> 
> Current version of Seabios is causing blue screen on Windows2003 when 64bit PCI resource is present and occupies high memory.
> 
> BSOD Error code is: 0x000000A5 (0x02, 0xFFFFfADF6A446880, 0x1, 0xFFFFFADFAA34690)
> 
> The issue is localized, it is related to presence of 64bit resource in _CRS method.
> 
> If we disable a 64bit region from _CRS  the Win2003 load normally but this doesn't allow Windows to use 64bit resources.
> 
> At the moment I have no idea how to fix this. Please help! 

I wonder if Windows 2003 does not support ConcatenateResTemplate.  The patch below
is obviously wrong, but should let you check if this is the issue:

git diff src/acpi-dsdt.dsl
diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
index 72dc7d8..11a9c92 100644
--- a/src/acpi-dsdt.dsl
+++ b/src/acpi-dsdt.dsl
@@ -175,9 +175,6 @@ DefinitionBlock (
                     0x00000000,         // Address Translation Offset
                     0x1EC00000,         // Address Length
                     ,, PW32, AddressRangeMemory, TypeStatic)
-            })
-            Name (CR64, ResourceTemplate ()
-            {
                 QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
                     0x00000000,          // Address Space Granularity
                     0x8000000000,        // Address Range Minimum
@@ -221,20 +218,14 @@ DefinitionBlock (
 		Store (P0EL, PE32)
 		Store (P0LL, PL32)
 
-		If (LAnd(LEqual(P1SL, 0x00), LEqual(P1SH, 0x00))) {
-		    Return (CRES)
-		} Else {
 		    /* fixup 64bit pci io window */
-		    CreateQWordField (CR64,\_SB.PCI0.PW64._MIN, PS64)
-		    CreateQWordField (CR64,\_SB.PCI0.PW64._MAX, PE64)
-		    CreateQWordField (CR64,\_SB.PCI0.PW64._LEN, PL64)
+		    CreateQWordField (CRES,\_SB.PCI0.PW64._MIN, PS64)
+		    CreateQWordField (CRES,\_SB.PCI0.PW64._MAX, PE64)
+		    CreateQWordField (CRES,\_SB.PCI0.PW64._LEN, PL64)
 		    Store (P1S, PS64)
 		    Store (P1E, PE64)
 		    Store (P1L, PL64)
-		    /* add window and return result */
-		    ConcatenateResTemplate (CRES, CR64, Local0)
-		    Return (Local0)
-		}
+		    Return (CRES)
             }
         }
     }

Paolo

      parent reply	other threads:[~2012-08-03 16:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 15:38 [Qemu-devel] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present Alexey Korolev
2012-07-28 15:27 ` Kevin O'Connor
2012-07-28 16:51   ` [Qemu-devel] [SeaBIOS] " Fred .
2012-07-28 17:52   ` [Qemu-devel] " Alexey Korolev
2012-08-06  8:21   ` Gerd Hoffmann
2012-07-29 15:51 ` Paolo Bonzini
2012-08-03 16:29 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501BFC51.5020005@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Alexey.Korolev@endace.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).