From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxNXD-00029C-0V for qemu-devel@nongnu.org; Fri, 03 Aug 2012 15:27:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxNXB-0003sD-TL for qemu-devel@nongnu.org; Fri, 03 Aug 2012 15:27:42 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:55151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxNXB-0003p4-Pa for qemu-devel@nongnu.org; Fri, 03 Aug 2012 15:27:41 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 15:27:35 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 867B46E8045 for ; Fri, 3 Aug 2012 15:27:31 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q73JRUCR337308 for ; Fri, 3 Aug 2012 15:27:30 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q73JRT0K030014 for ; Fri, 3 Aug 2012 16:27:30 -0300 Message-ID: <501C261E.40406@us.ibm.com> Date: Fri, 03 Aug 2012 14:27:26 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1343981180-23817-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343981180-23817-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , Herve Poussineau , qemu-devel@nongnu.org On 08/03/2012 03:06 AM, Paolo Bonzini wrote: > Anthony, > > The following changes since commit 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: > > Merge remote-tracking branch 'mst/tags/for_anthony' into staging (2012-07-30 10:00:48 -0500) > > are available in the git repository at: > > > git://github.com/bonzini/qemu.git scsi-next > > for you to fetch changes up to b71760ef6180662cc2dff1f6cf673a53508c59f1: > > scsi: add support for ATA_PASSTHROUGH_xx scsi command (2012-08-03 10:04:37 +0200) > > The main change here is re-enabling megasas, but there's also Herve's > retro HBA and a couple of random fixes. CC sparc-softmmu/target-sparc/mmu_helper.o CC sparc-softmmu/target-sparc/ldst_helper.o CC sparc-softmmu/target-sparc/int32_helper.o LINK sparc-softmmu/qemu-system-sparc ../libhw64/hw/esp.o: In function `dc390_read_config': /home/anthony/git/qemu/hw/esp.c:1220: undefined reference to `pci_default_read_config' ../libhw64/hw/esp.o: In function `dc390_write_config': /home/anthony/git/qemu/hw/esp.c:1245: undefined reference to `pci_default_write_config' collect2: ld returned 1 exit status make[1]: *** [qemu-system-sparc] Error 1 make: *** [subdir-sparc-softmmu] Error 2 It looks like sparc does link in esp.c but doesn't support pci (at least pci.o). I must admit, it's not obvious to me whether pci.o should be added to the sparc build or whether esp.c needs to be refactored. Regards, Anthony Liguori > > ---------------------------------------------------------------- > Cong Meng (1): > scsi: add support for ATA_PASSTHROUGH_xx scsi command > > Hannes Reinecke (1): > megasas: static SAS addresses > > Hervé Poussineau (2): > esp: add missing const on TypeInfo structures > esp: add Tekram DC-390 emulation (PC SCSI adapter) > > Paolo Bonzini (3): > scsi-disk: fix compilation with DEBUG_SCSI > Revert "megasas: disable due to build breakage" > esp: enable for all PCI machines > > Ronnie Sahlberg (2): > SCSI: Update the sense code for PREVENT REMOVAL errors > SCSI: STARTSTOPUNIT only eject/load media if powercondition is 0 > > Stefan Weil (1): > megasas: Update function megasys_scsi_uninit > > default-configs/i386-softmmu.mak | 1 - > default-configs/pci.mak | 2 + > hw/esp.c | 130 +++++++++++++++++++++++++++++++++++++- > hw/megasas.c | 68 ++++++++++++++------ > hw/mfi.h | 1 + > hw/scsi-bus.c | 92 +++++++++++++++++++++++++-- > hw/scsi-defs.h | 4 +- > hw/scsi-disk.c | 29 +++++---- > 8 files changed, 286 insertions(+), 41 deletions(-)