From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SxNzW-0002Kk-5s
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 15:56:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SxNzU-0003ci-Uf
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 15:56:58 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:43197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SxNzU-0003cb-JV
	for qemu-devel@nongnu.org; Fri, 03 Aug 2012 15:56:56 -0400
Received: by wgbfm10 with SMTP id fm10so745396wgb.10
	for <qemu-devel@nongnu.org>; Fri, 03 Aug 2012 12:56:55 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <501C2D04.5020205@redhat.com>
Date: Fri, 03 Aug 2012 21:56:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1343981180-23817-1-git-send-email-pbonzini@redhat.com>
	<501C261E.40406@us.ibm.com>
In-Reply-To: <501C261E.40406@us.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Herve Poussineau <hpoussin@reactos.org>, qemu-devel@nongnu.org

Il 03/08/2012 21:27, Anthony Liguori ha scritto:
> On 08/03/2012 03:06 AM, Paolo Bonzini wrote:
>> Anthony,
>>
>> The following changes since commit
>> 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a:
>>
>>    Merge remote-tracking branch 'mst/tags/for_anthony' into staging
>> (2012-07-30 10:00:48 -0500)
>>
>> are available in the git repository at:
>>
>>
>>    git://github.com/bonzini/qemu.git scsi-next
>>
>> for you to fetch changes up to b71760ef6180662cc2dff1f6cf673a53508c59f1:
>>
>>    scsi: add support for ATA_PASSTHROUGH_xx scsi command (2012-08-03
>> 10:04:37 +0200)
>>
>> The main change here is re-enabling megasas, but there's also Herve's
>> retro HBA and a couple of random fixes.
> 
>   CC    sparc-softmmu/target-sparc/mmu_helper.o
>   CC    sparc-softmmu/target-sparc/ldst_helper.o
>   CC    sparc-softmmu/target-sparc/int32_helper.o
>   LINK  sparc-softmmu/qemu-system-sparc
> ../libhw64/hw/esp.o: In function `dc390_read_config':
> /home/anthony/git/qemu/hw/esp.c:1220: undefined reference to
> `pci_default_read_config'
> ../libhw64/hw/esp.o: In function `dc390_write_config':
> /home/anthony/git/qemu/hw/esp.c:1245: undefined reference to
> `pci_default_write_config'
> collect2: ld returned 1 exit status
> make[1]: *** [qemu-system-sparc] Error 1
> make: *** [subdir-sparc-softmmu] Error 2
> 
> It looks like sparc does link in esp.c but doesn't support pci (at least
> pci.o).  I must admit, it's not obvious to me whether pci.o should be
> added to the sparc build or whether esp.c needs to be refactored.

I think the latter.

I removed this patch and pushed the rest (commit e4b6526) at the same
location.  Blue/Herve, can you look at esp.c?

Paolo