qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
Date: Mon, 06 Aug 2012 09:31:19 +0200	[thread overview]
Message-ID: <501F72C7.5040607@redhat.com> (raw)
In-Reply-To: <1343471002-14640-1-git-send-email-alevy@redhat.com>

> diff --git a/configure b/configure
> index cef0a71..5fcd315 100755
> --- a/configure
> +++ b/configure
> @@ -2630,7 +2630,7 @@ EOF
>    spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
>    spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
>    if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \
> -     $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 && \
> +     $pkg_config --atleast-version=0.12.0 spice-protocol > /dev/null 2>&1 && \

I'd prefer to not require cutting-edge spice bits to build ...

>      case QXL_IO_FLUSH_SURFACES_ASYNC:
> +#if SPICE_SERVER_VERSION >= 0x000b01 /* 0.11.1 */
> +    case QXL_IO_MONITORS_CONFIG_ASYNC:
> +#endif

... and given you #ifdef the new stuff anyway it should not be needed.

cheers,
  Gerd

  reply	other threads:[~2012-08-06  7:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 13:08 [Qemu-devel] [PATCH 1/2] qxl: disallow unknown revisions Alon Levy
2012-07-23 13:08 ` [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Alon Levy
2012-07-23 16:33   ` [Qemu-devel] [PATCH v2] " Alon Levy
2012-07-25  9:00     ` Yonit Halperin
2012-07-25 17:29       ` Alon Levy
2012-07-26  5:26         ` Yonit Halperin
2012-07-28  8:56         ` Alon Levy
2012-07-28  9:01           ` Blue Swirl
2012-07-28 10:20             ` Alon Levy
2012-07-28 10:23             ` [Qemu-devel] [PATCH v3] " Alon Levy
2012-08-06  7:31               ` Gerd Hoffmann [this message]
2012-08-09 13:41                 ` Alon Levy
2012-08-09 13:50                   ` Gerd Hoffmann
2012-08-09 14:18                     ` Alon Levy
2012-08-09 14:21                     ` [Qemu-devel] [PATCH v4 1/2] " Alon Levy
2012-08-09 14:21                       ` [Qemu-devel] [PATCH v4 2/2] configure: print spice-protocol and spice-server versions Alon Levy
2012-08-15  8:23                       ` [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC Gerd Hoffmann
2012-08-15 10:32                         ` Alon Levy
2012-08-15 10:43                           ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501F72C7.5040607@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yhalperi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).