From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyKxA-0006nd-CY for qemu-devel@nongnu.org; Mon, 06 Aug 2012 06:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyKx9-0000Cw-CX for qemu-devel@nongnu.org; Mon, 06 Aug 2012 06:54:28 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:57270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyKx8-0000Cb-QY for qemu-devel@nongnu.org; Mon, 06 Aug 2012 06:54:27 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Aug 2012 20:53:50 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q76Ajn3j22282340 for ; Mon, 6 Aug 2012 20:45:54 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q76AsBk1004773 for ; Mon, 6 Aug 2012 20:54:11 +1000 Message-ID: <501FA24F.20106@linux.vnet.ibm.com> Date: Mon, 06 Aug 2012 18:54:07 +0800 From: Lei Li MIME-Version: 1.0 References: <1342706962-11268-1-git-send-email-lilei@linux.vnet.ibm.com> <87394nbb72.fsf@codemonkey.ws> In-Reply-To: <87394nbb72.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-char: (Re-)connect for tcp_chr_write() unconnected writing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org Cc: Lei Li Ping? On 07/20/2012 07:09 AM, Anthony Liguori wrote: > Lei Li writes: >> tcp_chr_write() did not deal with writing to an unconnected >> connection and return the original length of the data, it's >> not right and would cause false writing. So (re-)connect it >> and return 0 for this situation. >> >> Signed-off-by: Lei Li > Looks good. > > Reviewed-by: Anthony Liguori > > Regards, > > Anthony Liguori > >> --- >> qemu-char.c | 7 +++++-- >> 1 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/qemu-char.c b/qemu-char.c >> index c2aaaee..25eaeeb 100644 >> --- a/qemu-char.c >> +++ b/qemu-char.c >> @@ -2141,14 +2141,17 @@ typedef struct { >> >> static void tcp_chr_accept(void *opaque); >> >> +static void tcp_chr_connect(void *opaque); >> + >> static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len) >> { >> TCPCharDriver *s = chr->opaque; >> if (s->connected) { >> return send_all(s->fd, buf, len); >> } else { >> - /* XXX: indicate an error ? */ >> - return len; >> + /* (Re-)connect for unconnected writing */ >> + tcp_chr_connect(chr); >> + return 0; >> } >> } >> >> -- >> 1.7.7.6 -- Lei