From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SyLPI-0005BV-Ri
	for qemu-devel@nongnu.org; Mon, 06 Aug 2012 07:23:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SyLPH-0008Sk-Qq
	for qemu-devel@nongnu.org; Mon, 06 Aug 2012 07:23:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SyLPH-0008Sf-Ip
	for qemu-devel@nongnu.org; Mon, 06 Aug 2012 07:23:31 -0400
Message-ID: <501FA92D.8070207@redhat.com>
Date: Mon, 06 Aug 2012 13:23:25 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1344219522-11873-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<CAJSP0QVA6nJUk0A-h_0=aZEYADPS_o3Ub=gG4QtdPouQBhM9Zg@mail.gmail.com>
In-Reply-To: <CAJSP0QVA6nJUk0A-h_0=aZEYADPS_o3Ub=gG4QtdPouQBhM9Zg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2] qemu-img: use QemuOpts instead of
 QEMUOptionParameter in resize function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 06.08.2012 12:14, schrieb Stefan Hajnoczi:
> On Mon, Aug 6, 2012 at 3:18 AM, Dong Xu Wang <wdongxu@linux.vnet.ibm.com> wrote:
>>
>> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>> ---
>> v1->v2: fix param leak.
>>
>>  qemu-img.c |   28 +++++++++++++++++-----------
>>  1 files changed, 17 insertions(+), 11 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

(But why do we even use any of the option functions instead of calling
strtosz_suffix?)

Kevin