From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling
Date: Mon, 06 Aug 2012 15:20:38 +0200 [thread overview]
Message-ID: <501FC4A6.2090803@redhat.com> (raw)
In-Reply-To: <CAJSP0QUkz_O8KR=1ztX3F_TTtK=RweNhm-237AEVpdbMY=UQHQ@mail.gmail.com>
Il 06/08/2012 14:48, Stefan Hajnoczi ha scritto:
>> > Interesting, I tested vhost (or thought so). Can you try this
>> > patch instead?
> Does this really make the code better than just reverting the patch?
The main problem here is that the current code has calls to
event_notifier_get_fd. These compile under Windows, but they will not
make sense when EventNotifier is ported to Windows because it will not
have a file descriptor. So I want to remove event_notifier_get_fd from
public code, and reverting the patch is a step backwards.
> I don't like this name because virtio-blk-data-plane also wants to use
> the ioeventfd. I suggest we call it use_handler (note logic is
> reversed from with_vhost).
Ok, noted.
Paolo
prev parent reply other threads:[~2012-08-06 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:58 [Qemu-devel] [PATCH] Revert "virtio: move common ioeventfd handling out of virtio-pci" Stefan Hajnoczi
2012-08-03 16:16 ` [Qemu-devel] [untested PATCH] virtio: fix vhost handling Paolo Bonzini
2012-08-06 12:48 ` Stefan Hajnoczi
2012-08-06 13:20 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501FC4A6.2090803@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).