From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyNEp-0003J8-67 for qemu-devel@nongnu.org; Mon, 06 Aug 2012 09:20:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyNEj-0005fX-6J for qemu-devel@nongnu.org; Mon, 06 Aug 2012 09:20:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyNEi-0005fR-SV for qemu-devel@nongnu.org; Mon, 06 Aug 2012 09:20:45 -0400 Message-ID: <501FC4A6.2090803@redhat.com> Date: Mon, 06 Aug 2012 15:20:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344005906-32176-1-git-send-email-stefanha@linux.vnet.ibm.com> <1344010598-4441-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Il 06/08/2012 14:48, Stefan Hajnoczi ha scritto: >> > Interesting, I tested vhost (or thought so). Can you try this >> > patch instead? > Does this really make the code better than just reverting the patch? The main problem here is that the current code has calls to event_notifier_get_fd. These compile under Windows, but they will not make sense when EventNotifier is ported to Windows because it will not have a file descriptor. So I want to remove event_notifier_get_fd from public code, and reverting the patch is a step backwards. > I don't like this name because virtio-blk-data-plane also wants to use > the ioeventfd. I suggest we call it use_handler (note logic is > reversed from with_vhost). Ok, noted. Paolo