From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyOGS-0002Jc-Ku for qemu-devel@nongnu.org; Mon, 06 Aug 2012 10:26:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyOGM-0006Ki-Es for qemu-devel@nongnu.org; Mon, 06 Aug 2012 10:26:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyOGM-0006Ic-76 for qemu-devel@nongnu.org; Mon, 06 Aug 2012 10:26:30 -0400 Message-ID: <501FD40E.8030506@redhat.com> Date: Mon, 06 Aug 2012 08:26:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344158004-10370-1-git-send-email-owasserm@redhat.com> <1344158004-10370-3-git-send-email-owasserm@redhat.com> In-Reply-To: <1344158004-10370-3-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA77EB737C951808433167E58" Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA77EB737C951808433167E58 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/05/2012 03:13 AM, Orit Wasserman wrote: > The management can enable/disable a capability for the next migration b= y using > migrate-set-apabilities QMP command. s/set-apabilities/set-capabilities/ > The management can query the current migration capabilities using > query-migrate-capabilities QMP command. > The user can use migrate_set_capability and 'info migrate_capabilities'= HMP > commands. >=20 > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > @@ -1419,6 +1433,8 @@ show user network stack connection states > show migration status > @item info migrate_supported_capabilities > show migrate supported capabilities > +@item info migrate_capabilities > +show current migration capabilities In HMP, are migrate_supported_capabilities and migrate_capabilities redundant? That is, I think I can use either command to answer both questions "what capabilities exist" and "what is the current state of all capabilities that exist", since _both_ commands output a list of capability names as well as an on/off designator. If my analysis is right, then we don't need migrate_supported_capabilities. > +++ b/qapi-schema.json > @@ -345,6 +345,27 @@ > { 'command': 'query-migrate-supported-capabilities', 'returns': ['Migr= ationCapabilityStatus'] } After all, in QMP, 'query-migrate-supported-capabilities'... > =20 > ## > +# @migrate-set-capabilities > +# > +# Enable/Disable the following migration capabilities (like xbzrle) > +# Missing a line, something like: # @capabilities: json array of capability modifications to make > +# Since: 1.2 > +## > +{ 'command': 'migrate-set-capabilities', > + 'data': { 'capabilities': ['MigrationCapabilityStatus'] } } > + > +## > +# @query-migrate-capabilities > +# > +# Returns information about the current migration capabilities status > +# > +# Returns: @MigrationCapabilitiesStatus > +# > +# Since: 1.2 > +## > +{ 'command': 'query-migrate-capabilities', 'returns': ['MigrationCap= abilityStatus']} =2E..and 'query-migrate-capabilities' return the same information. So we= don't need two commands, just one would do. Spacing was awkward before that '['. I would recommend that you s/[_-]supported// in patch 1/11, then removed query-migrate-capabilities in 2/11 (having moved it to 1/11), leaving 2/11 to just focus on migrate-set-capabilities. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA77EB737C951808433167E58 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQH9QOAAoJEKeha0olJ0Nq+kwIAIJ30VsiQrdvG+ajFmIhtvO0 O+7YGtQiX7CJYzbugF0BZTuSaSzDPWl+PRkTPu34pYo8+zQMKFJq8f95PSEt279G oECnn/2zdNL+1kZHrEBAjbGR2cJRd6Z+QywgB/+VLzaYXu1JfCcRPWiAsZX3VA45 LlISislMWdYg0UkDOF41qR5e4I09pQtrqHkNpxlc4/pCyxwmh91aAW0CQwGxLhb0 sAsjZbq9zVGmWYYw2/ZOOg/r9NNqY73N880p9CNljLtUYmwqh+Fhu/Smzwc7x6jA 1eNNYHExonV/Vw+0NaPZLtA53crKfpDqnPUV1F2MOEt9ZnGW6ASBRlIdfKu5JpM= =3UQT -----END PGP SIGNATURE----- --------------enigA77EB737C951808433167E58--