Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On 08/05/2012 03:13 AM, Orit Wasserman wrote:
> Change XBZRLE cache size in bytes (the size should be a power of 2, it will be
> rounded down to the nearest power of 2).
> If XBZRLE cache size is too small there will be many cache miss.
> 
> New query-migrate-cache-size QMP command and 'info migrate_cache_size' HMP
> command to query cache value.
> 

> +# @query-migrate-cache-size
> +#
> +# query XBZRLE cache size
> +#
> +# Returns: XBZRLE cache size in bytes
> +#
> +# Since: 1.2
> +##
> +{ 'command': 'query-migrate-cache-size', 'returns': 'int' }

This claims you return an int...


> +Example:
> +
> +-> { "execute": "migrate-set-cache-size", "arguments": { "value": 536870912 } }

...but while this example passes an int,...

> +Example:
> +
> +-> { "execute": "query-migrate-cache-size" }
> +<- { "return": { "size":"67108864" } }

...this example is returning a JSON object '{"size":"67108864"}' instead
of an int '67108864'.  Libvirt shouldn't care which of the two styles
you return, but it does need to be consistent between the schema, code,
and example (I didn't check the code to see which one of the two styles
was really in use).

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]