From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyPX5-0008Ll-QA for qemu-devel@nongnu.org; Mon, 06 Aug 2012 11:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyPWz-0005lW-DC for qemu-devel@nongnu.org; Mon, 06 Aug 2012 11:47:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyPWz-0005lR-5G for qemu-devel@nongnu.org; Mon, 06 Aug 2012 11:47:45 -0400 Message-ID: <501FE6ED.1070907@redhat.com> Date: Mon, 06 Aug 2012 09:46:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344158004-10370-1-git-send-email-owasserm@redhat.com> <1344158004-10370-9-git-send-email-owasserm@redhat.com> In-Reply-To: <1344158004-10370-9-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig64F5F05C18DBCC75724ED7DD" Subject: Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig64F5F05C18DBCC75724ED7DD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it = will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. >=20 > New query-migrate-cache-size QMP command and 'info migrate_cache_size' = HMP > command to query cache value. >=20 > +# @query-migrate-cache-size > +# > +# query XBZRLE cache size > +# > +# Returns: XBZRLE cache size in bytes > +# > +# Since: 1.2 > +## > +{ 'command': 'query-migrate-cache-size', 'returns': 'int' } This claims you return an int... > +Example: > + > +-> { "execute": "migrate-set-cache-size", "arguments": { "value": 5368= 70912 } } =2E..but while this example passes an int,... > +Example: > + > +-> { "execute": "query-migrate-cache-size" } > +<- { "return": { "size":"67108864" } } =2E..this example is returning a JSON object '{"size":"67108864"}' instea= d of an int '67108864'. Libvirt shouldn't care which of the two styles you return, but it does need to be consistent between the schema, code, and example (I didn't check the code to see which one of the two styles was really in use). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig64F5F05C18DBCC75724ED7DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQH+btAAoJEKeha0olJ0Nqjk8IAJogRsMJzVX1ypewJSPThrrt XTZfuOYX0g1CNWyxs804xMnaPKqLd3FtG8yGoHPS/shkFxx41n1nh10DyEA1wXIX PzBnpgkywkdj/nCmYZ0jcTUUzdsx212Gctk1rKaB4pfGYaTgZxEKVaQhdn8Elr8g BSf24iNpw9tL0BryLY56B4biVcFkEK4LXlI9qOp5WTzaevTwyScw+PlkPJHum6hV NJ11JdM4ZaYtsMfGaoQv+qkD1jn6g5VPexiEU69E+3bSG9LDePIEz8r4M7xmy4MM wLBmR8/zO+J76B3jYsLudqedHKO552Iazq2BCapk2V4WmfZXeHdR9WgGn2YXuXE= =c1PO -----END PGP SIGNATURE----- --------------enig64F5F05C18DBCC75724ED7DD--