From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyPf8-00034P-8X for qemu-devel@nongnu.org; Mon, 06 Aug 2012 11:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyPf7-00088U-4p for qemu-devel@nongnu.org; Mon, 06 Aug 2012 11:56:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyPf6-00088L-Sp for qemu-devel@nongnu.org; Mon, 06 Aug 2012 11:56:09 -0400 Message-ID: <501FE904.1080900@redhat.com> Date: Mon, 06 Aug 2012 09:55:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344158004-10370-1-git-send-email-owasserm@redhat.com> <1344158004-10370-11-git-send-email-owasserm@redhat.com> In-Reply-To: <1344158004-10370-11-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig451F23BE265D715B4605AC1F" Subject: Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig451F23BE265D715B4605AC1F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 28 ++++++++++++++++++++++++++++ > hmp.c | 13 +++++++++++++ > migration.c | 17 +++++++++++++++++ > migration.h | 4 ++++ > qapi-schema.json | 28 +++++++++++++++++++++++++++- > qmp-commands.hx | 32 +++++++++++++++++++++++++++++++- > 6 files changed, 120 insertions(+), 2 deletions(-) >=20 > diff --git a/arch_init.c b/arch_init.c > index 7f12317..9833d54 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -203,7 +203,11 @@ int64_t xbzrle_cache_resize(int64_t new_size) > typedef struct AccountingInfo { > uint64_t dup_pages; > uint64_t norm_pages; > + uint64_t xbzrle_bytes; > + uint64_t xbzrle_pages; > + uint64_t xbzrle_cache_miss; > uint64_t iterations; > + uint64_t xbzrle_overflows; Any reason you stagger where these stats are stored, rather than piling them all at the end? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig451F23BE265D715B4605AC1F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQH+kEAAoJEKeha0olJ0Nqd6UIAKshzm0qXuhKVh35L1mQCQGX aKROarzoKRpcVpnHb6N2RkviWdaei6fPEQfOG+8jcTNTHwUmEryjwfiuXDAowrnn sk7AbDmoyKj+aTrDxT/m+fR6QOQI1G8d/Ep8srCHp551g6CGMYkY8RYgh4VKB/1j Ifdy0X1G16DgU1FD4lOpaX/MufqgitIBAq8Ll8vU6VstypYwMd39rHYovAlZSoo6 yU9zSCFIcQ+D35OPXut1hc9pX08NspfNnDrALoeoJy4C3eSqtPU2GXze+l/Y72W8 mMqFo1+wVEvVjZrfPPKmtxmQcZvEfxeXLEPNFlTeaDmHhLV/anTB/3murxIjcdM= =ip7W -----END PGP SIGNATURE----- --------------enig451F23BE265D715B4605AC1F--