From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyPo3-000847-2I for qemu-devel@nongnu.org; Mon, 06 Aug 2012 12:05:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyPnw-0003E5-TX for qemu-devel@nongnu.org; Mon, 06 Aug 2012 12:05:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyPnw-0003E0-LD for qemu-devel@nongnu.org; Mon, 06 Aug 2012 12:05:16 -0400 Message-ID: <501FEB19.3030007@redhat.com> Date: Mon, 06 Aug 2012 19:04:41 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1344158004-10370-1-git-send-email-owasserm@redhat.com> <1344158004-10370-3-git-send-email-owasserm@redhat.com> <501FD40E.8030506@redhat.com> In-Reply-To: <501FD40E.8030506@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com On 08/06/2012 05:26 PM, Eric Blake wrote: > On 08/05/2012 03:13 AM, Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by using >> migrate-set-apabilities QMP command. > > s/set-apabilities/set-capabilities/ > >> The management can query the current migration capabilities using >> query-migrate-capabilities QMP command. >> The user can use migrate_set_capability and 'info migrate_capabilities' HMP >> commands. >> >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quintela >> --- > >> @@ -1419,6 +1433,8 @@ show user network stack connection states >> show migration status >> @item info migrate_supported_capabilities >> show migrate supported capabilities >> +@item info migrate_capabilities >> +show current migration capabilities > > In HMP, are migrate_supported_capabilities and migrate_capabilities > redundant? That is, I think I can use either command to answer both > questions "what capabilities exist" and "what is the current state of > all capabilities that exist", since _both_ commands output a list of > capability names as well as an on/off designator. If my analysis is > right, then we don't need migrate_supported_capabilities. No 'info migrate_supported_capabilities' shows the capabilities this version of QEMU can supports. and 'info migrate_capabilities' show what are the state of capabilities for the migration, i.e what is enabled. > >> +++ b/qapi-schema.json >> @@ -345,6 +345,27 @@ >> { 'command': 'query-migrate-supported-capabilities', 'returns': ['MigrationCapabilityStatus'] } > > After all, in QMP, 'query-migrate-supported-capabilities'... > >> >> ## >> +# @migrate-set-capabilities >> +# >> +# Enable/Disable the following migration capabilities (like xbzrle) >> +# > > Missing a line, something like: > > # @capabilities: json array of capability modifications to make > >> +# Since: 1.2 >> +## >> +{ 'command': 'migrate-set-capabilities', >> + 'data': { 'capabilities': ['MigrationCapabilityStatus'] } } >> + >> +## >> +# @query-migrate-capabilities >> +# >> +# Returns information about the current migration capabilities status >> +# >> +# Returns: @MigrationCapabilitiesStatus >> +# >> +# Since: 1.2 >> +## >> +{ 'command': 'query-migrate-capabilities', 'returns': ['MigrationCapabilityStatus']} > > ...and 'query-migrate-capabilities' return the same information. So we > don't need two commands, just one would do. > > Spacing was awkward before that '['. > > I would recommend that you s/[_-]supported// in patch 1/11, then removed > query-migrate-capabilities in 2/11 (having moved it to 1/11), leaving > 2/11 to just focus on migrate-set-capabilities. see above. > Orit