From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRo5-0002Bo-9O for qemu-devel@nongnu.org; Mon, 06 Aug 2012 14:13:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyRo3-0000Kk-RH for qemu-devel@nongnu.org; Mon, 06 Aug 2012 14:13:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRo3-0000KZ-JC for qemu-devel@nongnu.org; Mon, 06 Aug 2012 14:13:31 -0400 Message-ID: <5020093F.7020506@redhat.com> Date: Mon, 06 Aug 2012 12:13:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344275489-28789-1-git-send-email-owasserm@redhat.com> <1344275489-28789-9-git-send-email-owasserm@redhat.com> In-Reply-To: <1344275489-28789-9-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigD2AACA96F6AAE683455A8DAE" Subject: Re: [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD2AACA96F6AAE683455A8DAE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/06/2012 11:51 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it = will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. >=20 > New query-migrate-cache-size QMP command and 'info migrate_cache_size' = HMP > command to query cache value. >=20 > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +# > +# Since: 1.2 > +## > +{ 'command': 'query-migrate-cache-size', 'returns': 'int' } This is the first 'returns':'int' in the schema, but we do have a 'returns':'str' for comparison of returning a native type instead of a further struct. > +Example: > + > +-> { "execute": "query-migrate-cache-size" } > +<- { "return": { "67108864" } } Invalid JSON. Inside an {}, everything has to be in name:value pairs, but you gave no name to your string. But given the above, you aren't returning a string, but an int. I think this should be: { "return": 67108864 } That's based solely off my reading of the schema, and not of the code itself, so please actually execute your code, to see what really came over the wire. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigD2AACA96F6AAE683455A8DAE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQIAk/AAoJEKeha0olJ0NqRksH/jZ5JgRwUGw7IrNs30I5gc4c Nf4CSoYIMCbPeQP0rvdvTQPqxywnQRsxHDr+st+KmdnrfUuyPA6XpsAoZnu2tPQS 4fpOeyvWOKgFHq1V+7iEJ4+j2ktz1XxnHFse0c7GMICydZuC68iWA5UoQyVgpdwO d8qMJK7IN7YU8Qkl+tO6bUlueAp9johJ7APE6RZhhS65XX+6SuMFqQzaMPZnMulv Kjzs2OpLgTMOMK3yo/ZtMc0JnIPhxj21Pq/8DyEEgMxg2oaDLCcaNKU29lWMgkur 2G3eHH93wdQg+JC9c0weObTTDcVMiUshgBLD+vpEowD5NOIw3dR+jJ7xwXuUNOU= =Joav -----END PGP SIGNATURE----- --------------enigD2AACA96F6AAE683455A8DAE--