From: Eric Blake <eblake@redhat.com>
To: Orit Wasserman <owasserm@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com
Subject: Re: [Qemu-devel] [PATCH 10/12] Change total_time to total-time in MigrationStats
Date: Mon, 06 Aug 2012 12:15:25 -0600 [thread overview]
Message-ID: <502009BD.3030403@redhat.com> (raw)
In-Reply-To: <1344275489-28789-11-git-send-email-owasserm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On 08/06/2012 11:51 AM, Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
Sparse on the commit message. You need to document why the change is
safe (namely, call out which commit introduced 'total_time' in the first
place, and the fact that the commit is not part of 1.1, so we are fixing
an unreleased naming glitch). Also, I would suggest rebasing this to
occur before 9/11.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-08-06 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 17:51 [Qemu-devel] [PATCH 00/12] Migration next v11 Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 01/12] Add migration capabilities Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 02/12] Add migrate-set-capabilities Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 03/12] Add XBZRLE documentation Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 04/12] Add cache handling functions Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 05/12] Add uleb encoding/decoding functions Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 06/12] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 07/12] Add XBZRLE to ram_save_block and ram_save_live Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command Orit Wasserman
2012-08-06 18:13 ` Eric Blake
2012-08-06 18:24 ` Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 09/12] Add migration accounting for normal and duplicate pages Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 10/12] Change total_time to total-time in MigrationStats Orit Wasserman
2012-08-06 18:15 ` Eric Blake [this message]
2012-08-06 17:51 ` [Qemu-devel] [PATCH 11/12] Add XBZRLE statistics Orit Wasserman
2012-08-06 17:51 ` [Qemu-devel] [PATCH 12/12] Restart optimization on stage3 update version Orit Wasserman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502009BD.3030403@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=chegu_vinod@hp.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).