From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRq2-0003Kx-RD for qemu-devel@nongnu.org; Mon, 06 Aug 2012 14:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyRq1-0000x7-O4 for qemu-devel@nongnu.org; Mon, 06 Aug 2012 14:15:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRq1-0000wz-EJ for qemu-devel@nongnu.org; Mon, 06 Aug 2012 14:15:33 -0400 Message-ID: <502009BD.3030403@redhat.com> Date: Mon, 06 Aug 2012 12:15:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344275489-28789-1-git-send-email-owasserm@redhat.com> <1344275489-28789-11-git-send-email-owasserm@redhat.com> In-Reply-To: <1344275489-28789-11-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig10E2AD192A3BE453D1FD0D51" Subject: Re: [Qemu-devel] [PATCH 10/12] Change total_time to total-time in MigrationStats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10E2AD192A3BE453D1FD0D51 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/06/2012 11:51 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman Sparse on the commit message. You need to document why the change is safe (namely, call out which commit introduced 'total_time' in the first place, and the fact that the commit is not part of 1.1, so we are fixing an unreleased naming glitch). Also, I would suggest rebasing this to occur before 9/11. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig10E2AD192A3BE453D1FD0D51 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQIAm9AAoJEKeha0olJ0NqdX4IAKbPLwyKJv8HPpRaZSvAqS0k vO6WWZrJ7r4O2zxHhz4pf+QVObvM6KhGoCUZqtWF7Psr3irCC6fYJpCDyTD/fgX/ F0Pt3eEmIfB6zYzngD67kgwxy+SS99/IojxKFT4s5Kqmo0pH2RGQ5a68eSREMwos PU1rm9R6jf4fi514w7djYTgBkJ2mBwBGW9CVbNjdeB+lmEsGM8XQVT8/lLgveXoM VZ1gxFxPqkz9oMgybnpOtA8NEN+7TcGLhy70sj5uNKfWkSzKVsT+1jF+UG9jMg6k 2z69CwjwchZYNhmCvM/brrLpIiCexKW55PC/QISvVStQX9BKCmTNGjNzN+sM5UM= =iQQA -----END PGP SIGNATURE----- --------------enig10E2AD192A3BE453D1FD0D51--