From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyVJJ-0007K0-Ip for qemu-devel@nongnu.org; Mon, 06 Aug 2012 17:58:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyVJH-0004Qx-Nq for qemu-devel@nongnu.org; Mon, 06 Aug 2012 17:58:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyVJH-0004QZ-Eg for qemu-devel@nongnu.org; Mon, 06 Aug 2012 17:57:59 -0400 Message-ID: <50203DE5.2070302@redhat.com> Date: Mon, 06 Aug 2012 15:57:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344285891-6578-1-git-send-email-kwolf@redhat.com> <1344285891-6578-12-git-send-email-kwolf@redhat.com> <50203CFF.5000401@redhat.com> In-Reply-To: <50203CFF.5000401@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF6A15CB33173569AE3AADC6F" Subject: Re: [Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org, anthony@codemonkey.ws This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF6A15CB33173569AE3AADC6F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/06/2012 03:54 PM, Eric Blake wrote: > On 08/06/2012 02:44 PM, Kevin Wolf wrote: >> qemu-iotests already filters out image creation options that may be >> present or not in order to get the same output in both cases. However,= >> often it only considers the default value of the option. Cover all val= id >> values instead so that ./check -o name=3Dvalue can be used successfull= for >> all of them. >> >=20 >> +++ b/tests/qemu-iotests/common.rc >> @@ -110,11 +110,11 @@ _make_test_img() >> sed -e "s#$IMGFMT#IMGFMT#g" | \ >> sed -e "s# encryption=3Doff##g" | \ >> sed -e "s# cluster_size=3D[0-9]\\+##g" | \ >> - sed -e "s# table_size=3D0##g" | \ >> + sed -e "s# table_size=3D[0-9]\\+##g" | \ >=20 > Technically, use of \+ in a sed expression is undefined by POSIX. Oh, one other thing. This wastes a lot of processes by making a huge pipeline. Why not just do it with one sed process instead? sed -e "s# encryption=3Doff##g" \ -e "s# cluster_size=3D..." \ -e ... --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF6A15CB33173569AE3AADC6F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQID3lAAoJEKeha0olJ0NqhJQH/0Amw7c6l7yMjnLNEpvCpAUp trByhrG9iy6PLIA/Lil9VeasG5wvztuAx4HdlZ5BKF4FFy1Ij+mDXI21bFzJtcqh eaO+GgoXDvIjWHkqn5LMS3PRNXELcKscNlO4KuUWqoDP7rCPbNkWuzjdjYtcYH4c wSaH6LekbhtOM2afXIsKXMnr3syAYb3ia2PbT95udaUnv3e87u+wTZCzKxHB03h2 bVVX7rc8GI8Pi7d42k1xzf8ZrjU6cuwBVyBIgr4Wq0hweUjDUEXBpe6TENtciGH8 qSU+cKiz91N6RQsNyorG0TRndP1MPJ+E87Inpj1Aqkn5tuhmJeaRFIv81NvIlsQ= =33h+ -----END PGP SIGNATURE----- --------------enigF6A15CB33173569AE3AADC6F--