From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SydEo-0005ui-K8 for qemu-devel@nongnu.org; Tue, 07 Aug 2012 02:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SydEn-0004JG-K5 for qemu-devel@nongnu.org; Tue, 07 Aug 2012 02:25:54 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:59592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SydEn-0004Gz-Ai for qemu-devel@nongnu.org; Tue, 07 Aug 2012 02:25:53 -0400 Received: by wibhm2 with SMTP id hm2so1849227wib.10 for ; Mon, 06 Aug 2012 23:25:51 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5020B4ED.5090905@redhat.com> Date: Tue, 07 Aug 2012 08:25:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343793936-28000-1-git-send-email-david@gibson.dropbear.id.au> <501FCF45.4010003@redhat.com> <20120807040203.GM16664@truffala.fritz.box> In-Reply-To: <20120807040203.GM16664@truffala.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] eventfd: making it thread safe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , anthony@codemonkey.ws, qemu-devel@nongnu.org, Alexey Kardashevskiy , mst@redhat.com Il 07/08/2012 06:02, David Gibson ha scritto: >> Perhaps it's better to do this unconditionally (on the delete path too) >> so that removals are processed without delay and we don't have closed >> fds hanging around in select(). > > Well, I understand that Alexey discussed the patch with Paolo and > Michael Tsirkin, and this was the preferred approach for now. Since > obviously no events will happen on deleted fds, removing them from the > select() is not really urgent. Avi is not speaking about deleted fds, but about existing fds whose handlers are temporarily removed. I don't see it as a blocker for merging the patch because we've never observed it (and it's unlikely, because temporary removal of handlers typically occurs from within a handler, not from another thread). Paolo