From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyjFw-0005pt-UD for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyjFu-0005Gi-8n for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:51:28 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:33287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyjFt-00056j-Ip for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:51:26 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Aug 2012 18:21:17 +0530 Message-ID: <50210F32.8040105@linux.vnet.ibm.com> Date: Tue, 07 Aug 2012 20:50:58 +0800 From: Li Zhang MIME-Version: 1.0 References: <1344307320-25094-2-git-send-email-zhlcindy@linux.vnet.ibm.com> <1344341985-10065-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1344341985-10065-1-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC] usb and s390 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: qemu-ppc@nongnu.org, aliguori@us.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, Jens Freimann , Li Zhang , Eugene Dvurechenski , afaerber@suse.de, david@gibson.dropbear.id.au On 2012年08月07日 20:19, Christian Borntraeger wrote: > 2nd attempt, with mailing lists on cc.... > This patch reminded us of another thing that we have been working on. > Here is a patch that sits in my patch queue and disables usb for s390 > We have not pushed that patch yet, since several libvirt versions will always > specify -usb, which will then break. > > So are there any opinions about handling the usb option for platforms that > actually dont support it? My patches removed the usb_enabled global variable. So platforms can't use the global variable any more. Platforms created usb controller according to usb_enabled global variable before. Now we add USB option to machine options. For the platfrom, usb_enabled is got from machine option as the following: QemuOpts *mach_opts; bool usb_enabled = false; (If the platform needs to default value as true, it should be set as true ) mach_opts = qemu_opts_find(qemu_find_opts("machine"), 0); if (mach_opts) { usb_enabled = qemu_opt_get_bool(mach_opts, "usb", false); } > > Christian > > - > Eugene Dvurechenski (1): > USB code fenced for s390 > > configure | 66 +++++++++++++++++++++++++++++++++++++++++------------ > hmp-commands.hx | 6 +++++ > hw/Makefile.objs | 5 ++- > monitor.c | 4 +++ > qemu-options.hx | 4 +++ > sysemu.h | 2 + > vl.c | 8 +++++- > 7 files changed, 76 insertions(+), 19 deletions(-) > -- Li Zhang IBM China Linux Technology Centre