From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SykDP-00016Q-G6
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 09:53:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SykDO-0002LF-DY
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 09:52:55 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57977 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SykDO-0002LA-6j
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 09:52:54 -0400
Message-ID: <50211DB2.4010300@suse.de>
Date: Tue, 07 Aug 2012 15:52:50 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <3c770151454e19e279d1ecae8bb4daaf456df9de.1344344200.git.phrdina@redhat.com>
In-Reply-To: <3c770151454e19e279d1ecae8bb4daaf456df9de.1344344200.git.phrdina@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be
	optional
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: qemu-devel@nongnu.org

Am 07.08.2012 15:03, schrieb Pavel Hrdina:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

This is in need of a more detailed commit message: What exactly is this
fixing? Or is this a preparation for a particular new command?

Andreas

> ---
>  monitor.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/monitor.c b/monitor.c
> index bbf30e6..2b3583c 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Mon=
itor *mon,
>                      val =3D 1;
>                  } else if (p - beg =3D=3D 3 && !memcmp(beg, "off", p -=
 beg)) {
>                      val =3D 0;
> +                } else if (*typestr =3D=3D '?') {
> +                    typestr++;
> +                    break;
>                  } else {
>                      monitor_printf(mon, "Expected 'on' or 'off'\n");
>                      goto fail;
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg