* [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional
@ 2012-08-07 13:03 Pavel Hrdina
2012-08-07 13:52 ` Andreas Färber
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Hrdina @ 2012-08-07 13:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Pavel Hrdina
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
monitor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/monitor.c b/monitor.c
index bbf30e6..2b3583c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
val = 1;
} else if (p - beg == 3 && !memcmp(beg, "off", p - beg)) {
val = 0;
+ } else if (*typestr == '?') {
+ typestr++;
+ break;
} else {
monitor_printf(mon, "Expected 'on' or 'off'\n");
goto fail;
--
1.7.11.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional
2012-08-07 13:03 [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional Pavel Hrdina
@ 2012-08-07 13:52 ` Andreas Färber
2012-08-07 13:58 ` Pavel Hrdina
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2012-08-07 13:52 UTC (permalink / raw)
To: Pavel Hrdina; +Cc: qemu-devel
Am 07.08.2012 15:03, schrieb Pavel Hrdina:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This is in need of a more detailed commit message: What exactly is this
fixing? Or is this a preparation for a particular new command?
Andreas
> ---
> monitor.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index bbf30e6..2b3583c 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
> val = 1;
> } else if (p - beg == 3 && !memcmp(beg, "off", p - beg)) {
> val = 0;
> + } else if (*typestr == '?') {
> + typestr++;
> + break;
> } else {
> monitor_printf(mon, "Expected 'on' or 'off'\n");
> goto fail;
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional
2012-08-07 13:52 ` Andreas Färber
@ 2012-08-07 13:58 ` Pavel Hrdina
2012-08-07 14:36 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Hrdina @ 2012-08-07 13:58 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel
On 08/07/2012 03:52 PM, Andreas Färber wrote:
> Am 07.08.2012 15:03, schrieb Pavel Hrdina:
>> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> This is in need of a more detailed commit message: What exactly is this
> fixing? Or is this a preparation for a particular new command?
>
> Andreas
Yes, this is preparation for update of savevm command. I forget to write
it. And I think that in future this could be useful.
Pavel
>> ---
>> monitor.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/monitor.c b/monitor.c
>> index bbf30e6..2b3583c 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
>> val = 1;
>> } else if (p - beg == 3 && !memcmp(beg, "off", p - beg)) {
>> val = 0;
>> + } else if (*typestr == '?') {
>> + typestr++;
>> + break;
>> } else {
>> monitor_printf(mon, "Expected 'on' or 'off'\n");
>> goto fail;
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional
2012-08-07 13:58 ` Pavel Hrdina
@ 2012-08-07 14:36 ` Markus Armbruster
2012-08-07 14:37 ` Pavel Hrdina
0 siblings, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2012-08-07 14:36 UTC (permalink / raw)
To: Pavel Hrdina; +Cc: Andreas Färber, qemu-devel
Pavel Hrdina <phrdina@redhat.com> writes:
> On 08/07/2012 03:52 PM, Andreas Färber wrote:
>> Am 07.08.2012 15:03, schrieb Pavel Hrdina:
>>> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>> This is in need of a more detailed commit message: What exactly is this
>> fixing? Or is this a preparation for a particular new command?
>>
>> Andreas
> Yes, this is preparation for update of savevm command. I forget to
> write it. And I think that in future this could be useful.
Recommend to resend as part of a series that actually uses it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional
2012-08-07 14:36 ` Markus Armbruster
@ 2012-08-07 14:37 ` Pavel Hrdina
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Hrdina @ 2012-08-07 14:37 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Andreas Färber, qemu-devel
On 08/07/2012 04:36 PM, Markus Armbruster wrote:
> Pavel Hrdina <phrdina@redhat.com> writes:
>
>> On 08/07/2012 03:52 PM, Andreas Färber wrote:
>>> Am 07.08.2012 15:03, schrieb Pavel Hrdina:
>>>> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>>> This is in need of a more detailed commit message: What exactly is this
>>> fixing? Or is this a preparation for a particular new command?
>>>
>>> Andreas
>> Yes, this is preparation for update of savevm command. I forget to
>> write it. And I think that in future this could be useful.
> Recommend to resend as part of a series that actually uses it.
Ok, that was also my first thought, but the I told myself that it could
be better send it first alone.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-07 14:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-07 13:03 [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional Pavel Hrdina
2012-08-07 13:52 ` Andreas Färber
2012-08-07 13:58 ` Pavel Hrdina
2012-08-07 14:36 ` Markus Armbruster
2012-08-07 14:37 ` Pavel Hrdina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).