From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phrdina@redhat.com>) id 1SykId-0006Pt-I3
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 09:58:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phrdina@redhat.com>) id 1SykIc-0003y2-GX
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 09:58:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11015)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phrdina@redhat.com>) id 1SykIc-0003xt-8y
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 09:58:18 -0400
Message-ID: <50211EF7.4030409@redhat.com>
Date: Tue, 07 Aug 2012 15:58:15 +0200
From: Pavel Hrdina <phrdina@redhat.com>
MIME-Version: 1.0
References: <3c770151454e19e279d1ecae8bb4daaf456df9de.1344344200.git.phrdina@redhat.com>
	<50211DB2.4010300@suse.de>
In-Reply-To: <50211DB2.4010300@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be
	optional
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 08/07/2012 03:52 PM, Andreas F=E4rber wrote:
> Am 07.08.2012 15:03, schrieb Pavel Hrdina:
>> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> This is in need of a more detailed commit message: What exactly is this
> fixing? Or is this a preparation for a particular new command?
>
> Andreas
Yes, this is preparation for update of savevm command. I forget to write=20
it. And I think that in future this could be useful.

Pavel
>> ---
>>   monitor.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/monitor.c b/monitor.c
>> index bbf30e6..2b3583c 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Mo=
nitor *mon,
>>                       val =3D 1;
>>                   } else if (p - beg =3D=3D 3 && !memcmp(beg, "off", p=
 - beg)) {
>>                       val =3D 0;
>> +                } else if (*typestr =3D=3D '?') {
>> +                    typestr++;
>> +                    break;
>>                   } else {
>>                       monitor_printf(mon, "Expected 'on' or 'off'\n");
>>                       goto fail;
>>
>