From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyqZe-0002KC-7j for qemu-devel@nongnu.org; Tue, 07 Aug 2012 16:40:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyqZd-0007NW-2Y for qemu-devel@nongnu.org; Tue, 07 Aug 2012 16:40:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyqZc-0007NO-Pl for qemu-devel@nongnu.org; Tue, 07 Aug 2012 16:40:17 -0400 Message-ID: <50217D26.30108@redhat.com> Date: Tue, 07 Aug 2012 14:40:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344347073-7773-1-git-send-email-benoit@irqsave.net> <1344347073-7773-4-git-send-email-benoit@irqsave.net> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig666D54AB42A06CB0A1D48398" Subject: Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com, afaerber@suse.de, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig666D54AB42A06CB0A1D48398 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2012 02:30 PM, Blue Swirl wrote: > On Tue, Aug 7, 2012 at 1:44 PM, Beno=C3=AEt Canet wrote: >> Signed-off-by: Benoit Canet >> --- >> block/quorum.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++= +++++++++ >> 1 file changed, 62 insertions(+) >> >> diff --git a/block/quorum.c b/block/quorum.c >> index e0405b6..de58ab8 100644 >> --- a/block/quorum.c >> +++ b/block/quorum.c >> @@ -47,11 +47,73 @@ struct QuorumAIOCB { >> int vote_ret; >> }; >> >> +/* Valid quorum filenames look like >> + * quorum:path/to/a_image:path/to/b_image:path/to/c_image >=20 > This syntax would mean that stacking for example curl or other network > paths would not be possible. How about comma as separator? Also, what escaping mechanism is in place for allowing a file containing the same character as the separator (whether you end up with : or , as the separator)? If you support a larger quorum (whether always n/(2n-1) or whether fully configurable n/m), rather than hard-coded 2/3, then you also need a way to specify how many quorum members will follow. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig666D54AB42A06CB0A1D48398 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQIX0nAAoJEKeha0olJ0NqWXAH/1/t2yXnrWkCVNUbFLMcslHG rpigQGPkEBaywJu+uhr67JIKweje9I22fbB3foD8ih/zefPJs4THSe1g7mEz4yCc Oaeb0Fh7JVR5wCZSLnYVGSYetWlWPiYviEcXXr31Xd2myBKUu8S404n5CN8N82Cw hOLlJIn3fJoDcZ7szPxHu5mLseDa5Rz5i0y0rcOOi6GX1hU+m5NDcADOgCMX6zPR CNfNTo4IbqCL/OtTk+MunF5ZkJ18BS0U8AvC/piXOK8KbvNp7dkWHOYSIN69l56o sSFiRvrC1m37oDa+BfqW8slXBp7jGAd9V5zxF6vDeVz+xoeWxDWG756Y0J7RZOk= =k6PG -----END PGP SIGNATURE----- --------------enig666D54AB42A06CB0A1D48398--