From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sys53-0003JV-Gi for qemu-devel@nongnu.org; Tue, 07 Aug 2012 18:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sys52-0008Gn-B9 for qemu-devel@nongnu.org; Tue, 07 Aug 2012 18:16:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sys52-0008Gb-36 for qemu-devel@nongnu.org; Tue, 07 Aug 2012 18:16:48 -0400 Message-ID: <502193B5.30304@redhat.com> Date: Tue, 07 Aug 2012 16:16:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1344355108-14786-1-git-send-email-coreyb@linux.vnet.ibm.com> <1344355108-14786-3-git-send-email-coreyb@linux.vnet.ibm.com> <5021472E.3090501@redhat.com> <50214B5B.5030008@linux.vnet.ibm.com> In-Reply-To: <50214B5B.5030008@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig510579E5E8916D50B1D6CAB2" Subject: Re: [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig510579E5E8916D50B1D6CAB2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2012 11:07 AM, Corey Bryant wrote: >>> +# >>> +# Since: 1.2.0 >> >> We're not very consistent on '1.2' vs. '1.2.0' in since listings, but >> that's probably worth a global cleanup closer to hard freeze. >> >=20 > I'll make a note of it. Or does Luiz usually do a cleanup? No idea. >>> +## >>> +{ 'type': 'FdsetFdInfo', 'data': {'fd': 'int', 'removed': 'bool'} } >> >> Is it worth providing any additional information? For example, knowin= g >> whether the fd is O_RDONLY, O_WRONLY, or O_RDWR might be beneficial to= >> management apps trying to discover what fds are already present after = a >> reconnection, in order to decide whether to close them without having = to >> resort to /proc/$qemupid/fdinfo/nnn lookups. It might even be worth >> marking such information optional, present only when 'removed':false. >> >=20 > It makes sense but I'd like to limit the new functionality at this poin= t > so that I can get this support into QEMU 1.2. Can this be added as a > follow up patch? I'm personally okay with the idea of adding additional output fields in later releases, but I know that has been questioned in the past, so you may want to get buy-in from Luiz or Anthony. I guess the other thing is to see what libvirt would actually find useful, once I complete some counterpart libvirt patches. If libvirt can get by without any extra information and without needing to hack things from procfs, then it's not worth you spending the effort coding something that will be ignored; conversely, if a piece of info is so important that I end up hacking procfs anyways, that says we have a hole in QMP. I'm okay waiting for no= w. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig510579E5E8916D50B1D6CAB2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQIZO7AAoJEKeha0olJ0NqnUgH/AtXZrmDth2jUtcWWPE8c5/m GPrLCr9wUpZmPTXGnXu2d/wHIWhhp/NzHfR/LPB7QhlOPknijazvXJT311AUO5u/ CwUCl8NEIpcnmNJVnfhCbcNmaXXochucp1lwrspTfRD0sB5PGnBXxgZBBLjpjpFk IzHtaKytKTgCCSwxaijdchU/P9unxlMGTDa1gmn8JYaBB/2/l0L6yE1klxPxmTIT fHXDuKXm3++hVGOBgX1UOc1qEO6sA59jdlUcfsa8Q43gX8ogX3Pr65Gd1Sv4TBmp +pnueVIb8lhY7NmOQDD5RN7sQTSuPBulEmBE/rBhfvJ3b0n6S1/0aa+8qkyjcqw= =AWH3 -----END PGP SIGNATURE----- --------------enig510579E5E8916D50B1D6CAB2--