From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz17c-00033I-8u for qemu-devel@nongnu.org; Wed, 08 Aug 2012 03:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz17b-0003fi-8u for qemu-devel@nongnu.org; Wed, 08 Aug 2012 03:56:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz17b-0003fV-1B for qemu-devel@nongnu.org; Wed, 08 Aug 2012 03:56:03 -0400 Message-ID: <50221B89.50204@redhat.com> Date: Wed, 08 Aug 2012 09:55:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344222435-4759-1-git-send-email-peter.crosthwaite@petalogix.com> <1344222435-4759-2-git-send-email-peter.crosthwaite@petalogix.com> <1344383184.14961.10.camel@PetaLogix-ws2> In-Reply-To: <1344383184.14961.10.camel@PetaLogix-ws2> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, john.williams@petalogix.com, edgar.iglesias@gmail.com Il 08/08/2012 01:46, Peter Crosthwaite ha scritto: > Hi All, > > We seem to be having difficulty getting a review/merge on this patch. I > have sent two series, two pings and a PULL, with only a single reply > from P. Maydell asking for other reviewers to weigh in: > > --------- on July 17 P. Maydell wrote ----------- > > I guess I should mention that I'm assuming somebody else is going to > review > this patchset. It looks generally OK to me but whether the stream API > has the details of QOM interface use right is a bit out of my area > of expertise. > > -- PMM > > ------------------------------------------------ > > What needs to happen (and what can I do) to make this series go through? > Edgar has reviewed P2 this morning and I have already remade the series, > but my primary concern is this patch, considering it touches the core > QOM infrastructure. > > I have tested this patch on target i386 with no obvious breakages along > with testing on the the embedded platforms we work with (Zynq and MB). Acked-by: Paolo Bonzini :) Paolo