From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz7NC-000374-KW for qemu-devel@nongnu.org; Wed, 08 Aug 2012 10:36:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz7N4-00074Z-7t for qemu-devel@nongnu.org; Wed, 08 Aug 2012 10:36:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz7N3-00072V-VL for qemu-devel@nongnu.org; Wed, 08 Aug 2012 10:36:26 -0400 Message-ID: <5022795C.1020009@redhat.com> Date: Wed, 08 Aug 2012 08:36:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <5021AD24.6080806@intellilink.co.jp> In-Reply-To: <5021AD24.6080806@intellilink.co.jp> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig05D51F71B19607F7DB986EBC" Subject: Re: [Qemu-devel] [PATCH 0/5] support guest agent general command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "MATSUDA, Daiki" Cc: libvir-list@redhat.com, Michal Privoznik , QEMU Developers This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig05D51F71B19607F7DB986EBC Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: quoted-printable [adding qemu-devel, for a qemu-ga question] On 08/07/2012 06:04 PM, MATSUDA, Daiki wrote: > Hi, All. >=20 > I rewrote the patches as Eric suggested. >=20 >=20 >=20 > virsh # help qemu-agent-command > NAME > qemu-agent-command - Qemu Guest Agent Command >=20 > SYNOPSIS > qemu-agent-command [--timeout ] {[--cmd] }= =2E.. >=20 > virsh # qemu-agent-command RHEL58_64 '{"execute":"guest-info"}' > {"return":{"version":"1.1.50","supported_commands":[{"enabled":true,"na= me":"guest-network-get-interfaces"},{"enabled":true,"name":"guest-suspend= -hybrid"},... Question to the qemu folks - can we enhance 'guest-info' to tell us commands required to give output on success, vs. commands that are expected to never answer (except on possible error), so that libvirt can then make smarter decisions about whether to wait for a response for an arbitrary guest agent command? That is, I would love for the 'success-response' field of the qapi-schema-guest.json file to be exposed to libvirt, as it would greatly help in implementing Daiki's patchset for calling an arbitrary command and knowing whether to block on expecting a response rather than forcing the user to know which magic --timeout values to use. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig05D51F71B19607F7DB986EBC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQInlcAAoJEKeha0olJ0NqIbUIAIG0O9qwYoSyGITluHFjpfOt S5xAfKxSw1apISG8v9IYhtg2Bit96wfGCRpfXlrhP0D1RdaCW/tKAXdJATS9VPEb 2SzFMY3WntKaK8rtXcyv5YhlZ3BpjP5yY7F7bfjCnhzxZB5h62lgumlemgfko31A Hx+6zCmjc6PNgZJ7pyPNTArL/ol04c4NxVsS5v8goPvnp3FssECel5s5FO9lsMjS +tJWeEwsdAD37mLHZnU+f9yoOqGY/smjtuJ1luqkoY5ahmBwoozzIAutX6GAnN8l 87tUqwyOCWs65UlzIiGtEKeWefcmRWY9FM1khSCzoTsFN/zkn1woMOrqnOVg5cs= =RrZk -----END PGP SIGNATURE----- --------------enig05D51F71B19607F7DB986EBC--