From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzBbQ-0004dE-F8 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 15:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzBbP-0004vc-5J for qemu-devel@nongnu.org; Wed, 08 Aug 2012 15:07:32 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:41579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzBbP-0004vM-1I for qemu-devel@nongnu.org; Wed, 08 Aug 2012 15:07:31 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Aug 2012 15:07:26 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 7A0AC38C807A for ; Wed, 8 Aug 2012 15:07:06 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q78J74Uc29818916 for ; Wed, 8 Aug 2012 15:07:04 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q790buiM026052 for ; Wed, 8 Aug 2012 20:37:56 -0400 Message-ID: <5022B8D6.9070706@linux.vnet.ibm.com> Date: Wed, 08 Aug 2012 15:07:02 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1344355108-14786-1-git-send-email-coreyb@linux.vnet.ibm.com> <1344355108-14786-3-git-send-email-coreyb@linux.vnet.ibm.com> <5021472E.3090501@redhat.com> <50214B5B.5030008@linux.vnet.ibm.com> <502193B5.30304@redhat.com> In-Reply-To: <502193B5.30304@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , lcapitulino@redhat.com Cc: kwolf@redhat.com, libvir-list@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org On 08/07/2012 06:16 PM, Eric Blake wrote: > On 08/07/2012 11:07 AM, Corey Bryant wrote: > >>>> +# >>>> +# Since: 1.2.0 >>> >>> We're not very consistent on '1.2' vs. '1.2.0' in since listings, but >>> that's probably worth a global cleanup closer to hard freeze. >>> >> >> I'll make a note of it. Or does Luiz usually do a cleanup? > > No idea. > Luiz, were you planning to take a pass at cleaning up the "since" release? If not let me know and I can submit a patch. Just let me know which to use, '1.2' or '1.2.0'. >>>> +## >>>> +{ 'type': 'FdsetFdInfo', 'data': {'fd': 'int', 'removed': 'bool'} } >>> >>> Is it worth providing any additional information? For example, knowing >>> whether the fd is O_RDONLY, O_WRONLY, or O_RDWR might be beneficial to >>> management apps trying to discover what fds are already present after a >>> reconnection, in order to decide whether to close them without having to >>> resort to /proc/$qemupid/fdinfo/nnn lookups. It might even be worth >>> marking such information optional, present only when 'removed':false. >>> >> >> It makes sense but I'd like to limit the new functionality at this point >> so that I can get this support into QEMU 1.2. Can this be added as a >> follow up patch? > > I'm personally okay with the idea of adding additional output fields in > later releases, but I know that has been questioned in the past, so you > may want to get buy-in from Luiz or Anthony. I guess the other thing is > to see what libvirt would actually find useful, once I complete some > counterpart libvirt patches. If libvirt can get by without any extra > information and without needing to hack things from procfs, then it's > not worth you spending the effort coding something that will be ignored; > conversely, if a piece of info is so important that I end up hacking > procfs anyways, that says we have a hole in QMP. I'm okay waiting for now. > Assuming the list of to-do's for the next patch version remains minimal, I'll go ahead and add support to return the access mode flags from query-fdsets. Also, I'm going to remove in-use from the returned data, because it is always going to be true. -- Regards, Corey