From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzDFj-0000ye-LJ for qemu-devel@nongnu.org; Wed, 08 Aug 2012 16:53:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzDFf-0005Su-Qq for qemu-devel@nongnu.org; Wed, 08 Aug 2012 16:53:15 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:56579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzDFf-0005Sn-KK for qemu-devel@nongnu.org; Wed, 08 Aug 2012 16:53:11 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Aug 2012 14:53:10 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 8BBE619D803D for ; Wed, 8 Aug 2012 20:52:52 +0000 (WET) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q78Kql0v035010 for ; Wed, 8 Aug 2012 14:52:50 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q78Kqhjc000431 for ; Wed, 8 Aug 2012 14:52:43 -0600 Message-ID: <5022D199.1070402@linux.vnet.ibm.com> Date: Wed, 08 Aug 2012 16:52:41 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1344355108-14786-1-git-send-email-coreyb@linux.vnet.ibm.com> <1344355108-14786-3-git-send-email-coreyb@linux.vnet.ibm.com> <5021472E.3090501@redhat.com> <50214B5B.5030008@linux.vnet.ibm.com> <502193B5.30304@redhat.com> <5022B8D6.9070706@linux.vnet.ibm.com> <20120808174824.7565f531@doriath.home> In-Reply-To: <20120808174824.7565f531@doriath.home> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, Eric Blake On 08/08/2012 04:48 PM, Luiz Capitulino wrote: > On Wed, 08 Aug 2012 15:07:02 -0400 > Corey Bryant wrote: > >> >> >> On 08/07/2012 06:16 PM, Eric Blake wrote: >>> On 08/07/2012 11:07 AM, Corey Bryant wrote: >>> >>>>>> +# >>>>>> +# Since: 1.2.0 >>>>> >>>>> We're not very consistent on '1.2' vs. '1.2.0' in since listings, but >>>>> that's probably worth a global cleanup closer to hard freeze. >>>>> >>>> >>>> I'll make a note of it. Or does Luiz usually do a cleanup? >>> >>> No idea. >>> >> >> Luiz, were you planning to take a pass at cleaning up the "since" >> release? If not let me know and I can submit a patch. Just let me know >> which to use, '1.2' or '1.2.0'. > > I'd appreciate it if you submit a patch. I guess we should use 1.2.0. > Sure I'll do that. Btw, should I be using error_set(errp, ERROR_CLASS_GENERIC_ERROR, "...") and have a dependency on your patch series? Or should I stick with the old error messages? -- Regards, Corey