From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SzNLx-0001Yz-7K
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:40:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SzNLw-0003Ze-Bq
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:40:21 -0400
Received: from mail-gg0-f173.google.com ([209.85.161.173]:45644)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SzNLw-0003ZX-6l
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 03:40:20 -0400
Received: by ggna5 with SMTP id a5so128378ggn.4
	for <qemu-devel@nongnu.org>; Thu, 09 Aug 2012 00:40:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5023695A.80002@redhat.com>
Date: Thu, 09 Aug 2012 09:40:10 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1344407156-25562-1-git-send-email-qemulist@gmail.com>
	<1344407156-25562-16-git-send-email-qemulist@gmail.com>
	<502237CE.1020206@redhat.com>
	<CAJnKYQn-VNGE+tpDsR2w=vbO+DmMsvJN7qnQVNAH81=D_QJOpg@mail.gmail.com>
In-Reply-To: <CAJnKYQn-VNGE+tpDsR2w=vbO+DmMsvJN7qnQVNAH81=D_QJOpg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to
	unplug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, Stefan Hajnoczi <stefanha@gmail.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Il 09/08/2012 09:28, liu ping fan ha scritto:
>>> >> +static void
>>> >> +pci_e1000_unmap(PCIDevice *p)
>>> >> +{
>>> >> +    /* DO NOT FREE anything!until refcnt=0 */
>>> >> +    /* isolate from memory view */
>>> >> +}
>> >
>> > At least you need to call the superclass method.
>> >
> Refer to  0013-hotplug-introduce-qdev_unplug_complete-to-remove-dev.patch,
> we have the following sequence
> qdev_unmap->pci_unmap_device->pci_e1000_unmap.  So pci_e1000_unmap
> need not to do anything.

But then this patch is unnecessary, isn't it?

Paolo