From: Avi Kivity <avi@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: kvm@vger.kernel.org, "Jan Kiszka" <jan.kiszka@siemens.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Blue Swirl" <blauwirbel@gmail.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree
Date: Thu, 09 Aug 2012 11:31:14 +0300 [thread overview]
Message-ID: <50237552.9060107@redhat.com> (raw)
In-Reply-To: <CAJnKYQm_u=hEoj4egjTmzs6Pr5APojOU6rvjuhQ8FwNSa1=RAg@mail.gmail.com>
On 08/09/2012 10:27 AM, liu ping fan wrote:
> On Wed, Aug 8, 2012 at 5:42 PM, Avi Kivity <avi@redhat.com> wrote:
>> On 08/08/2012 09:25 AM, Liu Ping Fan wrote:
>>> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>>>
>>
>> Please explain the motivation. AFAICT, the big qemu lock is sufficient.
>>
> Oh, this is one of the series locks for the removal of big qemu lock.
Why do you want to remove the big qemu lock?
Even now it is not heavily contended. We should focus on fixing the
cases where is it contended, instead of removing it completely, which is
sure to make further development harder and is likely to introduce
locking bugs.
> The degradation of big lock will take several steps, including to
> introduce device's private lock. Till then, when the device add path
> from iothread and the remove path in io-dispatch is out of the big
> qemu lock. We need this extra lock.
>
> These series is too big, so I send out the 1st phase for review.
Even the first phase is too big.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-09 8:31 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 6:25 [Qemu-devel] [PATCH 0/15 v2] prepare unplug out of protection of global lock Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 01/15] atomic: introduce atomic operations Liu Ping Fan
2012-08-08 8:55 ` Paolo Bonzini
2012-08-08 9:02 ` Avi Kivity
2012-08-08 9:05 ` 陳韋任 (Wei-Ren Chen)
2012-08-08 9:15 ` Avi Kivity
2012-08-08 9:21 ` Peter Maydell
2012-08-08 13:09 ` Stefan Hajnoczi
2012-08-08 13:18 ` Paolo Bonzini
2012-08-08 13:32 ` Peter Maydell
2012-08-08 13:49 ` Paolo Bonzini
2012-08-08 14:00 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 02/15] qom: using atomic ops to re-implement object_ref Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 03/15] qom: introduce reclaimer to release obj Liu Ping Fan
2012-08-08 9:05 ` Avi Kivity
2012-08-08 9:07 ` Paolo Bonzini
2012-08-08 9:15 ` Avi Kivity
2012-08-09 7:33 ` liu ping fan
2012-08-09 7:49 ` Paolo Bonzini
2012-08-09 8:18 ` Avi Kivity
2012-08-10 6:43 ` liu ping fan
2012-08-08 9:35 ` Paolo Bonzini
2012-08-09 7:38 ` liu ping fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating Liu Ping Fan
2012-08-08 9:13 ` Avi Kivity
2012-08-09 7:28 ` liu ping fan
2012-08-09 8:24 ` Avi Kivity
2012-08-10 6:44 ` liu ping fan
2012-08-13 18:28 ` Marcelo Tosatti
2012-08-08 19:17 ` Blue Swirl
2012-08-09 7:28 ` liu ping fan
2012-08-09 17:09 ` Blue Swirl
2012-08-08 6:25 ` [Qemu-devel] [PATCH 05/15] memory: introduce life_ops to MemoryRegion Liu Ping Fan
2012-08-08 9:18 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 06/15] memory: use refcnt to manage MemoryRegion Liu Ping Fan
2012-08-08 9:20 ` Avi Kivity
2012-08-09 7:27 ` liu ping fan
2012-08-09 8:38 ` Avi Kivity
2012-08-10 6:44 ` liu ping fan
2012-08-12 8:43 ` Avi Kivity
2012-08-08 6:25 ` [Qemu-devel] [PATCH 07/15] memory: inc/dec mr's ref when adding/removing from mem view Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy Liu Ping Fan
2012-08-08 9:27 ` Avi Kivity
2012-08-08 19:18 ` Blue Swirl
2012-08-09 7:29 ` liu ping fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access Liu Ping Fan
2012-08-08 9:41 ` Avi Kivity
2012-08-11 1:58 ` liu ping fan
2012-08-11 10:06 ` liu ping fan
2012-08-08 19:23 ` Blue Swirl
2012-08-09 7:29 ` liu ping fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 10/15] memory: change tcg related code to using PhysMap Liu Ping Fan
2012-08-08 6:25 ` [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree Liu Ping Fan
2012-08-08 9:41 ` Paolo Bonzini
2012-08-09 7:28 ` liu ping fan
2012-08-09 7:41 ` Paolo Bonzini
2012-08-08 9:42 ` Avi Kivity
2012-08-09 7:27 ` liu ping fan
2012-08-09 8:31 ` Avi Kivity [this message]
2012-08-08 6:25 ` [Qemu-devel] [PATCH 12/15] qdev: using devtree lock to protect device's accessing Liu Ping Fan
2012-08-08 9:33 ` Peter Maydell
2012-08-08 6:25 ` [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views Liu Ping Fan
2012-08-08 9:52 ` Paolo Bonzini
2012-08-08 10:07 ` Avi Kivity
2012-08-09 7:28 ` liu ping fan
2012-08-09 8:00 ` Paolo Bonzini
2012-08-10 6:42 ` liu ping fan
2012-08-13 18:53 ` Marcelo Tosatti
2012-08-13 18:51 ` Marcelo Tosatti
2012-08-08 6:25 ` [Qemu-devel] [PATCH 14/15] qom: object_unref call reclaimer Liu Ping Fan
2012-08-08 9:40 ` Paolo Bonzini
2012-08-13 18:56 ` Marcelo Tosatti
2012-08-08 6:25 ` [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug Liu Ping Fan
2012-08-08 9:56 ` Paolo Bonzini
2012-08-09 7:28 ` liu ping fan
2012-08-09 7:40 ` Paolo Bonzini
2012-08-10 6:43 ` liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50237552.9060107@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).