From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzOaK-000211-Qx for qemu-devel@nongnu.org; Thu, 09 Aug 2012 04:59:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzOaE-0001fd-Ic for qemu-devel@nongnu.org; Thu, 09 Aug 2012 04:59:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzOaE-0001fX-Ai for qemu-devel@nongnu.org; Thu, 09 Aug 2012 04:59:10 -0400 Message-ID: <50237BDA.8030906@redhat.com> Date: Thu, 09 Aug 2012 10:59:06 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1341245761-30942-1-git-send-email-kraxel@redhat.com> <4FF3FA4D.5080702@rdsoftware.de> <4FFC7B12.8000307@rdsoftware.de> In-Reply-To: <4FFC7B12.8000307@rdsoftware.de> Content-Type: multipart/mixed; boundary="------------050108030400080901040403" Subject: Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik Rull Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------050108030400080901040403 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit > Hi Gerd, > > sorry for the delays, I tested the latest pulled patch queue and it's > now fine on my Intel board, too. The dongle gets detected again without > assertions. Thanks for your work. > > Still remaining are the multiple usb resets on host side before the > dongle gets finally detected / usable on the guest. Can you try if the attached patch makes a difference? thanks, Gerd --------------050108030400080901040403 Content-Type: text/plain; name="0001-async-control-xfer-fixup.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-async-control-xfer-fixup.patch" >>From d51ea0d80009eb58a09e8e571a7eca5da562becc Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Thu, 9 Aug 2012 10:57:32 +0200 Subject: [PATCH] async control xfer fixup Signed-off-by: Gerd Hoffmann --- hw/usb/core.c | 1 + hw/usb/host-linux.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index 01a7622..c7e5bc0 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -107,6 +107,7 @@ static int do_token_setup(USBDevice *s, USBPacket *p) } usb_packet_copy(p, s->setup_buf, p->iov.size); + p->result = 0; s->setup_len = (s->setup_buf[7] << 8) | s->setup_buf[6]; s->setup_index = 0; diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index d55be87..8df9207 100644 --- a/hw/usb/host-linux.c +++ b/hw/usb/host-linux.c @@ -1045,6 +1045,7 @@ static int usb_host_handle_control(USBDevice *dev, USBPacket *p, /* Note request is (bRequestType << 8) | bRequest */ trace_usb_host_req_control(s->bus_num, s->addr, p, request, value, index); + assert(p->result == 0); switch (request) { case DeviceOutRequest | USB_REQ_SET_ADDRESS: -- 1.7.1 --------------050108030400080901040403--