From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzPWH-0008BU-6A for qemu-devel@nongnu.org; Thu, 09 Aug 2012 05:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzPWG-0003Er-7E for qemu-devel@nongnu.org; Thu, 09 Aug 2012 05:59:09 -0400 Message-ID: <502389E4.7020500@redhat.com> Date: Thu, 09 Aug 2012 11:59:00 +0200 From: Kevin Wolf MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, armbru@redhat.com, agraf@suse.de, alex.williamson@redhat.com, avi@redhat.com, pbonzini@redhat.com, afaerber@suse.de Am 03.08.2012 21:57, schrieb Jason Baron: > Hi, > > While testing q35 I found data corruption on reads from the cdrom on the ahci > controller. The first patch addresses this issue. I also noticed that there is > a memory leak in the ahci code, which is addressed in the second patch. > > Thanks, > > -Jason > > > v2: > fprintf -> DPRINTF (so can't be triggered by guest) > 0 sglist fields > > > Jason Baron (2): > ahci: Fix ahci cdrom read corruptions for reads > 128k > ahci: Fix sglist memleak in ahci_dma_rw_buf() > > dma-helpers.c | 1 + > hw/ide/ahci.c | 44 +++++++++++++++++++++++++++++++++++++------- > hw/ide/internal.h | 1 + > 3 files changed, 39 insertions(+), 7 deletions(-) > Thanks, applied both to the block branch. Kevin