From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SzQgg-0008QE-37
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 07:13:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SzQgf-0002Ps-3X
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 07:13:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37602)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SzQge-0002Po-SC
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 07:13:57 -0400
Message-ID: <50239B70.5060308@redhat.com>
Date: Thu, 09 Aug 2012 13:13:52 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1344285891-6578-1-git-send-email-kwolf@redhat.com>
	<1344285891-6578-12-git-send-email-kwolf@redhat.com>
	<50203CFF.5000401@redhat.com> <50203DE5.2070302@redhat.com>
In-Reply-To: <50203DE5.2070302@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with
 image creation options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Am 06.08.2012 23:57, schrieb Eric Blake:
> On 08/06/2012 03:54 PM, Eric Blake wrote:
>> On 08/06/2012 02:44 PM, Kevin Wolf wrote:
>>> qemu-iotests already filters out image creation options that may be
>>> present or not in order to get the same output in both cases. However,
>>> often it only considers the default value of the option. Cover all valid
>>> values instead so that ./check -o name=value can be used successfull for
>>> all of them.
>>>
>>
>>> +++ b/tests/qemu-iotests/common.rc
>>> @@ -110,11 +110,11 @@ _make_test_img()
>>>      	sed -e "s#$IMGFMT#IMGFMT#g" | \
>>>  	sed -e "s# encryption=off##g" | \
>>>  	sed -e "s# cluster_size=[0-9]\\+##g" | \
>>> -	sed -e "s# table_size=0##g" | \
>>> +	sed -e "s# table_size=[0-9]\\+##g" | \
>>
>> Technically, use of \+ in a sed expression is undefined by POSIX.
> 
> Oh, one other thing.  This wastes a lot of processes by making a huge
> pipeline.  Why not just do it with one sed process instead?
> 
> sed -e "s# encryption=off##g" \
>     -e "s# cluster_size=..." \
>     -e ...

Makes sense, I'll send a patch.

Kevin