From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SzT8Y-0006oU-Qc
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 09:50:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SzT8U-0007OI-43
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 09:50:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SzT8T-0007Ns-14
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 09:50:50 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79DoESX030732
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 9 Aug 2012 09:50:19 -0400
Message-ID: <5023C014.2080407@redhat.com>
Date: Thu, 09 Aug 2012 15:50:12 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHtqYEQ7WruVAVcpaZDRdx0sO3182wcofmqPuOGBtf5+2A@mail.gmail.com>
	<1343471002-14640-1-git-send-email-alevy@redhat.com>
	<501F72C7.5040607@redhat.com>
	<20120809134122.GB6680@garlic.redhat.com>
In-Reply-To: <20120809134122.GB6680@garlic.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On 08/09/12 15:41, Alon Levy wrote:
> On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote:
>>> diff --git a/configure b/configure
>>> index cef0a71..5fcd315 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2630,7 +2630,7 @@ EOF
>>>    spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
>>>    spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
>>>    if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \
>>> -     $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 && \
>>> +     $pkg_config --atleast-version=0.12.0 spice-protocol > /dev/null 2>&1 && \
>>
>> I'd prefer to not require cutting-edge spice bits to build ...
> 
> I only increased the protocol requirement, not the server.

Distros tend to update those in sync, so this doesn't help much for the
average user, this change would likely cause spice detection fail on
almost every released distro ...

> Meanwhile I'll add a define based on the pkg-config spice-protocol
> version, which I can test from hw/qxl.c, since the commit adding
> QXL_IO_MONITORS_CONFIG_ASYNC didn't introduce any new define I can
> check.

Just checking "SPICE_SERVER_VERSION >= 0x000b01" doesn't work?  I'd
expect spice-server 0.11.1+ having a dependency on a recent enougth
spice-protocol so you can expect QXL_IO_MONITORS_CONFIG_ASYNC being
present then, no?

thanks,
  Gerd