From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SzUVy-0005kh-2c
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 11:19:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SzUVs-0002rR-7i
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 11:19:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SzUVr-0002rG-Va
	for qemu-devel@nongnu.org; Thu, 09 Aug 2012 11:19:04 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q79FJ2Pg029145
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 9 Aug 2012 11:19:02 -0400
Message-ID: <5023D4E5.3070802@redhat.com>
Date: Thu, 09 Aug 2012 09:19:01 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1344524511-9682-1-git-send-email-kwolf@redhat.com>
In-Reply-To: <1344524511-9682-1-git-send-email-kwolf@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enig590A9F93339C20B5A2A0CD3B"
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Save some sed processes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig590A9F93339C20B5A2A0CD3B
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 08/09/2012 09:01 AM, Kevin Wolf wrote:
> Instead of building a huge pipeline, just pass all expressions to a
> single sed process.
>=20
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/common.rc |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

>=20
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.r=
c
> index 7782808..6b80516 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -105,16 +105,16 @@ _make_test_img()
> =20
>      # XXX(hch): have global image options?
>      $QEMU_IMG create -f $IMGFMT $extra_img_options $TEST_IMG $image_si=
ze | \
> -    	sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" | \

> +        sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \

and nice to get rid of that space-followed-by-TAB indent.

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig590A9F93339C20B5A2A0CD3B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJQI9TlAAoJEKeha0olJ0NqSLQH/3L/2vXz1TdJ7drvT6P1NpRe
ZvXPON9ZsFv4lJqqxAK24+hWvJOZ9j7hnCz8ZltQVkGlNFD7M28Q6pMAzH/Q9eGU
JQYGXrefDItP7XV6zAkovXQS0GvaHoSoTAGHeKzolOYcsAbkX3o1yMi4wOa+I8SA
SzEriLJDktbCQdO4D3g7gYgQ4iPh6+vuMMa/NRf6IsPbiVCGnwON9gBHib8DFfG+
gzzZ1mpASY8CMj+tYbp8k3Vi6yMutQ5sRb/tSsXAoZL39oaH6FZd+VZOWlTmFfhc
hRjng3xqHe5LvmSLJrsQNGchX7yh6UnigBGiQHRtN98P7r55/6TnjSV+XmNWZOs=
=xZrD
-----END PGP SIGNATURE-----

--------------enig590A9F93339C20B5A2A0CD3B--