From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzX9R-0006ep-6g for qemu-devel@nongnu.org; Thu, 09 Aug 2012 14:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzX9Q-0004DF-DX for qemu-devel@nongnu.org; Thu, 09 Aug 2012 14:08:05 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:39319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzX9Q-0004Cr-3W for qemu-devel@nongnu.org; Thu, 09 Aug 2012 14:08:04 -0400 Received: by wibhm2 with SMTP id hm2so453431wib.10 for ; Thu, 09 Aug 2012 11:08:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5023FC7F.8050209@redhat.com> Date: Thu, 09 Aug 2012 20:07:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344519511-18147-1-git-send-email-pbonzini@redhat.com> <1344519511-18147-6-git-send-email-pbonzini@redhat.com> <5023F054.7090500@msgid.tls.msk.ru> In-Reply-To: <5023F054.7090500@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/7] scsi-disk: more assertions and resets for aiocb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org Il 09/08/2012 19:16, Michael Tokarev ha scritto: >> > Leaving the aiocb to a non-NULL value leads to an assertion failure when >> > rerror/werror are set to stop or enospc, and the operation is retried. >> > scsi-disk checks that the aiocb member is NULL before filling it. >> > >> > This patch correctly resets the aiocb to NULL values everywhere, >> > and adds the dual assertion that the aiocb was non-NULL before >> > calling bdrv_acct_done. > Stable matherial? Possibly, but quite unlikely to trigger (since this would happen only on flushes, basically). Paolo