Re: [Qemu-devel] [PATCH 3/4] qmp: qmp-events.txt: put events in alphabetical order

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2408 bytes --]

On 08/09/2012 11:28 AM, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  QMP/qmp-events.txt | 266 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 130 insertions(+), 136 deletions(-)

Code motion that deletes 6 more lines than it adds?  I'm assuming those
were blank lines, and that spacing is more consistent now, but it's
nicer to see a code motion patch with matching diffstat.

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index b8afedb..e37a04e 100644
> --- a/QMP/qmp-events.txt
> +++ b/QMP/qmp-events.txt

Nits to possibly address in a followup patch (do NOT fix them at the
same time as code motion, though):

>  
> +SPICE_CONNECTED, SPICE_DISCONNECTED
> +-----------------------------------
> +
> +Emitted when a SPICE client connects or disconnects.

Should this be broken into two listings?

> +SPICE_INITIALIZED
> +-----------------
> +
> +Emitted after initial handshake and authentication takes place (if any)
> +and the SPICE channel is up'n'running

Do we like this cutesy abbreviation, or should we spell out 'and'?

> +
> +Data:
> +
> +- "server": Server information (json-object)
> +  - "host": IP address (json-string)
> +  - "port": port number (json-string)
> +  - "family": address family (json-string, "ipv4" or "ipv6")
> +  - "auth": authentication method (json-string, optional)
> +- "client": Client information (json-object)
> +  - "host": IP address (json-string)
> +  - "port": port number (json-string)
> +  - "family": address family (json-string, "ipv4" or "ipv6")
> +  - "connection-id": spice connection id.  All channels with the same id
> +                     belong to the same spice session (json-int)
> +  - "channel-type": channel type.  "1" is the main control channel, filter for
> +                    this one if you want track spice sessions only (json-int)
> +  - "channel-id": channel id.  Usually "0", might be different needed when
> +                  multiple channels of the same type exist, such as multiple
> +                  display channels in a multihead setup (json-int)
> +  - "tls": whevener the channel is encrypted (json-bool)

s/whevener/whether/

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]